-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kvm docker machine base image #15628
Update kvm docker machine base image #15628
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 51.5s 51.7s 53.8s 53.0s 54.3s Times for minikube ingress: 27.2s 25.6s 23.7s 26.7s 27.2s docker driver with docker runtime
Times for minikube start: 26.3s 25.7s 24.4s 25.7s 26.0s Times for minikube ingress: 21.9s 19.9s 20.5s 22.4s 18.9s docker driver with containerd runtime
Times for minikube start: 22.2s 22.3s 22.0s 21.5s 21.6s Times for minikube ingress: 26.4s 26.0s 26.4s 25.9s 26.4s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
There seems there might be something weird going on in CI. If I build the But if I download https://storage.googleapis.com/minikube-builds/15628/docker-machine-driver-kvm2-amd64 the libvirt version is still old (1.2.19). However the LXC versions are correctly removed, so the build is successful but it's like it's using an old version of the image (Ubuntu 16) to build the with. Investigating what might be going on |
kvm2 driver with docker runtime
Times for minikube start: 54.4s 53.2s 55.0s 53.8s 54.9s Times for minikube (PR 15628) ingress: 25.2s 28.7s 28.7s 24.7s 25.2s docker driver with docker runtime
Times for minikube start: 25.6s 25.1s 27.8s 27.1s 27.1s Times for minikube ingress: 23.0s 20.0s 21.0s 21.0s 21.5s docker driver with containerd runtime
Times for minikube start: 22.1s 21.5s 22.6s 33.3s 26.2s Times for minikube ingress: 26.5s 26.5s 26.5s 26.5s 26.5s |
With debugging I was able to confirm that the file contains the expected libvirt version in CI, but the uploaded file has a different libvirt version, will continue investigating |
kvm2 driver with docker runtime
Times for minikube start: 53.4s 56.4s 56.4s 54.0s 54.4s Times for minikube ingress: 25.2s 26.7s 27.1s 23.1s 35.2s docker driver with docker runtime |
Confirmed that the binary shasum in CI doesn't match the file uploaded |
kvm2 driver with docker runtime
Times for minikube start: 56.6s 53.8s 56.0s 58.0s 54.7s Times for minikube ingress: 28.8s 28.8s 29.8s 29.7s 28.8s docker driver with docker runtime
Times for minikube ingress: 21.0s 20.5s 21.5s 20.5s 50.0s Times for minikube (PR 15628) start: 26.2s 27.4s 26.1s 25.8s 26.2s docker driver with containerd runtime
Times for minikube start: 22.1s 22.7s 23.7s 22.7s 22.6s Times for minikube (PR 15628) ingress: 26.0s 26.0s 26.0s 26.0s 26.0s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
Discovered the root of the problem, we aren't purging Docker on build in Jenkins so when it checks for the existing image it exists and doesn't rebuild it, resulting in my Dockerfile changes not being built and used. Will remove all the debugging changes and update CI to purge Docker on start. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube ingress: 27.8s 25.1s 25.2s 23.2s 29.1s Times for minikube start: 55.4s 54.3s 55.2s 55.0s 56.4s docker driver with docker runtime
Times for minikube start: 26.9s 26.6s 25.3s 25.7s 25.4s Times for minikube ingress: 20.9s 25.4s 20.5s 21.5s 22.0s docker driver with containerd runtime
Times for minikube start: 22.5s 21.4s 22.1s 22.0s 33.0s Times for minikube ingress: 26.5s 26.4s 26.4s 26.4s 25.9s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
without_lxc
tolibvirt_without_lxc
as per https://gitlab.com/libvirt/libvirt-go-module/-/merge_requests/34docker-machine-driver-kvm2-amd64
builder from Ubuntu 16.04 to Ubuntu 20.04 to fix libvirt build errordocker system prune -a --volumes -f
to cross build to clear out previous run artifactsThis makes the build on #15537 complete