Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buildkit to v0.11.0 #15630

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Update buildkit to v0.11.0 #15630

merged 2 commits into from
Jan 17, 2023

Conversation

kushmansingh
Copy link
Contributor

Before:
buildctl github.com/moby/buildkit v0.10.3

After:
buildctl github.com/moby/buildkit v0.11.0

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 12, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kushmansingh / name: Kush Mansingh (5a727cb)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kushmansingh!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kushmansingh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 12, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@kushmansingh kushmansingh force-pushed the kmansingh/buildkit11 branch 2 times, most recently from 1a2a3a4 to 5a727cb Compare January 12, 2023 14:37
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 12, 2023
@spowelljr
Copy link
Member

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @kushmansingh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15630) |
+----------------+----------+---------------------+
| minikube start | 54.6s    | 55.5s               |
| enable ingress | 27.4s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 54.1s 58.1s 54.0s 53.2s 53.5s
Times for minikube (PR 15630) start: 55.8s 54.9s 57.2s 54.1s 55.3s

Times for minikube ingress: 28.6s 29.7s 25.7s 28.7s 24.2s
Times for minikube (PR 15630) ingress: 25.2s 27.6s 24.2s 27.7s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15630) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 25.6s               |
| enable ingress | 20.4s    | 21.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.0s 19.0s 21.4s 19.5s 21.0s
Times for minikube (PR 15630) ingress: 23.0s 23.5s 21.0s 19.0s 20.5s

Times for minikube start: 24.9s 25.5s 24.2s 27.6s 26.7s
Times for minikube (PR 15630) start: 25.7s 26.6s 26.0s 24.7s 24.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15630) |
+----------------+----------+---------------------+
| minikube start | 24.1s    | 21.9s               |
| enable ingress | 32.5s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 57.4s 26.4s 26.0s 26.4s 26.4s
Times for minikube (PR 15630) ingress: 26.5s 26.5s 56.4s 26.0s 25.9s

Times for minikube start: 33.8s 21.2s 21.8s 22.0s 21.8s
Times for minikube (PR 15630) start: 22.0s 22.4s 21.8s 21.4s 21.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.00 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 9.93 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 9.93 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 9.93 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 9.93 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 10.22 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Stop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Stop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 10.22 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 10.22 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@afbjorklund afbjorklund changed the title Update github.com/moby/buildkit to v0.11.0 Update buildkit to v0.11.0 Jan 13, 2023
@afbjorklund
Copy link
Collaborator

Changed the title, because it sounded like a go dependency update (next to the other firehose of updates)

spowelljr
spowelljr approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kushmansingh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@spowelljr spowelljr merged commit 833d632 into kubernetes:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kushmansingh @k8s-ci-robot @minikube-bot @spowelljr @minikube-pr-bot @afbjorklund