Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: Fix printing the proper value of mount type #15731

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

p2c2e
Copy link
Contributor

@p2c2e p2c2e commented Jan 28, 2023

This is a Trivial change.
Before PR the "Mount type" is always printed as empty string - since the Infof() stmt is incorrect. The change should not affect any other functionality ...

minikube mount /tmp:/myhosttmp --v=7

📁  Mounting host path /tmp into VM as /myhosttmp ...
    ▪ Mount type:              <<<< MISSING VALUE
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.205.1:53992

After PR:

minikube mount /tmp:/myhosttmp --v=7

📁  Mounting host path /tmp into VM as /myhosttmp ...
    ▪ Mount type:   9p                       <<< Now CORRECT value is printed
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.205.1:53992

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @p2c2e. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p2c2e, r0b2g1t
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval by writing /assign @spowelljr in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Feb 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15731) |
+----------------+----------+---------------------+
| minikube start | 55.4s    | 56.0s               |
| enable ingress | 27.0s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.2s 28.2s 25.3s 25.3s 28.3s
Times for minikube (PR 15731) ingress: 24.8s 28.8s 28.2s 28.3s 26.2s

Times for minikube start: 54.7s 55.7s 55.0s 54.6s 57.1s
Times for minikube (PR 15731) start: 55.0s 55.7s 57.1s 55.7s 56.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15731) |
+----------------+----------+---------------------+
| minikube start | 27.4s    | 27.8s               |
| enable ingress | 39.3s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 27.5s 27.8s 26.9s 27.5s 27.5s
Times for minikube (PR 15731) start: 26.8s 27.2s 27.8s 27.3s 30.0s

Times for minikube ingress: 21.1s 21.1s 22.6s 50.1s 81.6s
Times for minikube (PR 15731) ingress: 20.1s 23.1s 21.1s 21.6s 49.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15731) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.8s               |
| enable ingress | 39.6s    | 40.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 22.6s 22.7s 21.7s 23.1s
Times for minikube (PR 15731) start: 22.7s 22.9s 23.3s 22.9s 22.1s

Times for minikube ingress: 33.6s 32.6s 32.6s 19.6s 79.6s
Times for minikube (PR 15731) ingress: 47.6s 33.6s 79.6s 20.6s 20.6s

@medyagh
Copy link
Member

medyagh commented Feb 13, 2023

thanks for this contribution, look forward to see more contributions from you @p2c2e

@medyagh medyagh merged commit ba699ac into kubernetes:master Feb 13, 2023
@medyagh medyagh changed the title Print proper value of mount type using info print statement mount: display proper value of mount type Feb 13, 2023
@medyagh medyagh changed the title mount: display proper value of mount type mount: Fix printing the proper value of mount type Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants