-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount: Fix printing the proper value of mount type #15731
Conversation
Hi @p2c2e. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: p2c2e, r0b2g1t The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube ingress: 28.2s 28.2s 25.3s 25.3s 28.3s Times for minikube start: 54.7s 55.7s 55.0s 54.6s 57.1s docker driver with docker runtime
Times for minikube start: 27.5s 27.8s 26.9s 27.5s 27.5s Times for minikube ingress: 21.1s 21.1s 22.6s 50.1s 81.6s docker driver with containerd runtime
Times for minikube start: 22.1s 22.6s 22.7s 21.7s 23.1s Times for minikube ingress: 33.6s 32.6s 32.6s 19.6s 79.6s |
thanks for this contribution, look forward to see more contributions from you @p2c2e |
This is a Trivial change.
Before PR the "Mount type" is always printed as empty string - since the Infof() stmt is incorrect. The change should not affect any other functionality ...
After PR: