-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP-Auth: Add fixes and timeouts #15985
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 53.6s 54.8s 53.8s 52.1s 53.4s Times for minikube ingress: 28.3s 27.3s 28.3s 28.3s 25.3s docker driver with docker runtime
Times for minikube ingress: 19.6s 20.1s 22.1s 21.1s 22.1s Times for minikube start: 25.8s 28.0s 27.2s 25.9s 27.2s docker driver with containerd runtime
Times for minikube start: 24.0s 22.1s 22.6s 23.2s 23.6s Times for minikube ingress: 31.6s 47.6s 47.6s 31.6s 31.6s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Fix 1
If you enable GCP-Auth with an older version of minikube and then try to refresh it with a newer version of minikube with different GCP-Auth images it will fail as it's trying to apply a patch using a different image. To fix this on the first
kubectl apply
don't use--force
, but on subsequent attempts use--force
, this will resolve the mentioned issue.Fix 2
refreshExistingPods
had an infinite retry with no timeout while waiting for a pod to come back up. Updated so each pod gets 15 seconds to come back up, also added info logging to help with future issues.