Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ceph rbd kernel driver to arm iso #16019

Merged
merged 2 commits into from
Jun 8, 2023
Merged

add ceph rbd kernel driver to arm iso #16019

merged 2 commits into from
Jun 8, 2023

Conversation

BlaineEXE
Copy link
Contributor

The Minikube ISO for aarch64 did not contain the Ceph kernel driver build parameters present for the x86_64 build. This is critical for running Rook (https://rook.io) storage on Minikube.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @BlaineEXE. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

afbjorklund
afbjorklund approved these changes Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, both arch should have the same features (where possible)

@afbjorklund
Copy link
Collaborator

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2023
@minikube-bot
Copy link
Collaborator

Hi @BlaineEXE, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/16019/fd560e7/iso_build.txt

@minikube-bot
Copy link
Collaborator

Hi @BlaineEXE, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2023
@BlaineEXE
Copy link
Contributor Author

@afbjorklund is there more I need to do? The tide bot says it needs a lgtm label.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 13, 2023
@BlaineEXE
Copy link
Contributor Author

BlaineEXE commented Apr 13, 2023 •
edited
Loading

@afbjorklund
Also, I'm not 100% sure what the rebase process should be when there is the ISO involved. Please let me know if I should be doing something different.

@afbjorklund
Copy link
Collaborator

Changes looked fine, guess it just didn't get included in the release... @spowelljr can you assist with the rebase/merge ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 3, 2023
@travisn
Copy link

travisn commented May 19, 2023

@afbjorklund @spowelljr Looking forward to getting this merged, what is needed? Thanks!

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2023
@BlaineEXE
Copy link
Contributor Author

Rebased again and removed the ISO commit. Do I need another ok-to-build-iso?

@travisn
Copy link

travisn commented Jun 6, 2023

Changes looked fine, guess it just didn't get included in the release... @spowelljr can you assist with the rebase/merge ?

@spowelljr What is needed? Thanks!

@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @BlaineEXE, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023
@BlaineEXE
add ceph rbd kernel driver to arm iso
1ce5be7 
The Minikube ISO for aarch64 did not contain the Ceph kernel driver
build parameters present for the x86_64 build. This is critical for
running Rook (https://rook.io) storage on Minikube.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023
@spowelljr
Copy link
Member

ok-to-build-iso

1 similar comment
@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @BlaineEXE, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2023
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16019) |
+----------------+----------+---------------------+
| minikube start | 52.4s    | 53.2s               |
| enable ingress | 27.8s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 51.8s 53.1s 53.8s 52.2s 51.0s
Times for minikube (PR 16019) start: 54.6s 55.4s 51.3s 53.4s 51.6s

Times for minikube (PR 16019) ingress: 28.2s 28.7s 25.2s 28.7s 28.2s
Times for minikube ingress: 29.2s 25.7s 27.7s 27.2s 29.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16019) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 24.9s               |
| enable ingress | 21.3s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 16019) start: 24.7s 25.4s 24.8s 24.5s 24.9s
Times for minikube start: 25.1s 22.2s 24.9s 25.1s 26.0s

Times for minikube ingress: 22.4s 20.9s 20.9s 21.4s 20.9s
Times for minikube (PR 16019) ingress: 20.4s 21.9s 20.9s 20.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16019) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 21.8s               |
| enable ingress | 27.2s    | 31.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.4s 21.4s 31.4s 32.4s 19.4s
Times for minikube (PR 16019) ingress: 31.4s 32.4s 31.4s 31.4s 31.4s

Times for minikube start: 23.5s 23.4s 20.3s 21.6s 23.6s
Times for minikube (PR 16019) start: 21.3s 20.5s 23.9s 20.2s 23.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/parallel/Version/components (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 3.45 (chart)
QEMU_macOS TestFunctional/serial/ComponentHealth (gopogh) 3.45 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, BlaineEXE, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit a424d1c into kubernetes:master Jun 8, 2023
@BlaineEXE BlaineEXE deleted the add-ceph-rbd-to-arm-iso branch June 9, 2023 16:49
@BlaineEXE BlaineEXE mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@spowelljr spowelljr spowelljr approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BlaineEXE @k8s-ci-robot @minikube-bot @afbjorklund @travisn @spowelljr @minikube-pr-bot