-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove container-runtime flag from later versions #16124
Conversation
Since k8s 1.24, the only available option is remote. It also now needs a socket URL, and not just a path.
The default ep is the same as for container-runtime Remove the extra config since it doesn't do anything
/ok-to-test |
The code is now the same for all runtimes (using CRI), and should be refactored. |
Tested with |
kvm2 driver with docker runtime
Times for minikube (PR 16124) start: 54.2s 58.6s 56.6s 59.6s 56.4s Times for minikube ingress: 28.4s 29.3s 29.3s 25.8s 25.7s docker driver with docker runtime
Times for minikube start: 25.8s 26.0s 27.2s 27.2s 26.7s Times for minikube ingress: 22.6s 25.1s 22.1s 20.1s 51.6s docker driver with containerd runtime
Times for minikube ingress: 32.6s 32.6s 32.6s 47.6s 31.6s Times for minikube start: 22.7s 23.6s 23.0s 22.1s 23.1s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
after removing the from /var/lib/kubelet/kubeadm-flags.env, now its working cat /var/lib/kubelet/kubeadm-flags.env |
The
--container-runtime
flag was deprecated in k8s 1.24, and removed in k8s 1.27Add the extra
unix://
prefix everywhere, and remove the redundant endpoint config.Closes #16112