Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove container-runtime flag from later versions #16124

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

afbjorklund
Copy link
Collaborator

The --container-runtime flag was deprecated in k8s 1.24, and removed in k8s 1.27

Add the extra unix:// prefix everywhere, and remove the redundant endpoint config.

Closes #16112

Since k8s 1.24, the only available option is remote.

It also now needs a socket URL, and not just a path.
The default ep is the same as for container-runtime

Remove the extra config since it doesn't do anything
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2023
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 21, 2023
@afbjorklund
Copy link
Collaborator Author

The code is now the same for all runtimes (using CRI), and should be refactored.

@afbjorklund
Copy link
Collaborator Author

Tested with ./out/minikube start --kubernetes-version=v1.27.0-beta.0 --preload=false

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16124) |
+----------------+----------+---------------------+
| minikube start | 54.7s    | 57.1s               |
| enable ingress | 27.7s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 16124) start: 54.2s 58.6s 56.6s 59.6s 56.4s
Times for minikube start: 57.0s 53.5s 55.1s 54.8s 53.0s

Times for minikube ingress: 28.4s 29.3s 29.3s 25.8s 25.7s
Times for minikube (PR 16124) ingress: 25.3s 28.8s 28.7s 29.3s 28.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16124) |
+----------------+----------+---------------------+
| minikube start | 26.6s    | 26.7s               |
| enable ingress | 28.3s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 25.8s 26.0s 27.2s 27.2s 26.7s
Times for minikube (PR 16124) start: 26.5s 26.2s 27.5s 26.9s 26.7s

Times for minikube ingress: 22.6s 25.1s 22.1s 20.1s 51.6s
Times for minikube (PR 16124) ingress: 21.1s 22.1s 23.1s 22.1s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16124) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 23.0s               |
| enable ingress | 35.4s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.6s 32.6s 32.6s 47.6s 31.6s
Times for minikube (PR 16124) ingress: 32.6s 31.6s 31.6s 32.6s 31.6s

Times for minikube start: 22.7s 23.6s 23.0s 22.1s 23.1s
Times for minikube (PR 16124) start: 22.8s 23.1s 23.8s 22.3s 23.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestNoKubernetes/serial/StartWithK8s (gopogh) 0.00 (chart)
KVM_Linux TestNoKubernetes/serial/StartWithStopK8s (gopogh) 0.00 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 100.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 5a072f0 into kubernetes:master Mar 22, 2023
@hritesh11
Copy link

after removing the from /var/lib/kubelet/kubeadm-flags.env, now its working

cat /var/lib/kubelet/kubeadm-flags.env
#KUBELET_KUBEADM_ARGS="--container-runtime=remote --container-runtime-endpoint=unix:///var/run/containerd/containerd.sock --pod-infra-container-image=registry.k8s.io/pause:3.8"
KUBELET_KUBEADM_ARGS=" --pod-infra-container-image=registry.k8s.io/pause:3.8"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube does not work with kubernetes 1.27 due to flag removal
5 participants