Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP-Auth: update kube-webhook-certgen image #16199

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

spowelljr
Copy link
Member

Fixes 43 CVEs

Before:

  LOW      | 1   
  MEDIUM   | 9   
  HIGH     | 34  
  CRITICAL | 1   

After:

  LOW      | 0  
  MEDIUM   | 1  
  HIGH     | 1  
  CRITICAL | 0  

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 30, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16199) |
+-------------------+----------+---------------------+
| minikube start    | 52.8s    | 52.4s               |
| ⚠️  enable ingress | 28.2s    | 38.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 56.4s 53.1s 50.7s 52.0s 51.8s
Times for minikube (PR 16199) start: 53.2s 53.3s 52.3s 50.6s 52.4s

Times for minikube (PR 16199) ingress: 24.7s 28.2s 24.7s 28.7s 85.7s
Times for minikube ingress: 25.7s 29.7s 25.3s 28.2s 32.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16199) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 23.7s               |
| enable ingress | 39.8s    | 20.6s               |
+----------------+----------+---------------------+

Times for minikube start: 24.3s 23.6s 23.7s 23.4s 24.5s
Times for minikube (PR 16199) start: 23.6s 24.1s 23.8s 22.9s 24.0s

Times for minikube ingress: 21.1s 82.1s 22.5s 23.1s 50.1s
Times for minikube (PR 16199) ingress: 20.1s 22.1s 21.1s 20.1s 19.6s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16199) |
+-------------------+----------+---------------------+
| minikube start    | 22.5s    | 22.1s               |
| ⚠️  enable ingress | 27.8s    | 41.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 22.6s 22.5s 22.4s 22.5s 22.7s
Times for minikube (PR 16199) start: 22.3s 22.3s 22.2s 21.6s 22.0s

Times for minikube ingress: 31.6s 33.6s 19.6s 32.6s 21.6s
Times for minikube (PR 16199) ingress: 48.7s 27.6s 31.6s 19.6s 79.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestNetworkPlugins/group/custom-flannel/Start (gopogh) 0.62 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 58.67 (chart)
Docker_macOS TestSkaffold (gopogh) 70.45 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 81.40 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 94.67 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 97.56 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)
none_Linux TestAddons/Setup (gopogh) 100.00 (chart)
none_Linux TestFunctional/parallel/DashboardCmd (gopogh) 100.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmdConnect (gopogh) 100.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 100.00 (chart)
none_Linux TestFunctional/serial/ExtraConfig (gopogh) 100.00 (chart)
none_Linux TestFunctional/serial/SoftStart (gopogh) 100.00 (chart)
none_Linux TestFunctional/serial/StartWithProxy (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 34cedd2 into kubernetes:master Mar 30, 2023
@spowelljr spowelljr deleted the updateGCPAuthWebhook branch March 30, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants