Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none driver: check for CNI plugins #16419

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

spowelljr
Copy link
Member

Closes #16378

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2023
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16419) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 50.3s               |
| enable ingress | 25.6s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 50.6s 52.9s 53.3s 47.5s 49.7s
Times for minikube (PR 16419) start: 48.8s 50.2s 48.3s 50.8s 53.1s

Times for minikube ingress: 27.6s 24.1s 24.6s 27.2s 24.7s
Times for minikube (PR 16419) ingress: 27.6s 28.1s 26.6s 28.2s 24.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16419) |
+-------------------+----------+---------------------+
| minikube start    | 23.5s    | 23.0s               |
| ⚠️  enable ingress | 21.6s    | 33.1s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 21.4s 22.9s 20.9s 21.9s 20.8s
Times for minikube (PR 16419) ingress: 81.4s 20.4s 20.8s 21.9s 20.9s

Times for minikube start: 25.0s 21.7s 25.9s 22.9s 21.7s
Times for minikube (PR 16419) start: 24.3s 21.9s 23.2s 22.7s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16419) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 24.2s               |
| enable ingress | 34.7s    | 31.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 21.0s 21.1s 23.5s 35.1s
Times for minikube (PR 16419) start: 23.4s 20.6s 33.0s 21.0s 22.9s

Times for minikube ingress: 31.3s 47.3s 31.4s 31.3s 32.4s
Times for minikube (PR 16419) ingress: 31.4s 30.4s 31.4s 30.3s 31.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.72 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 1.45 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/DeployApp (gopogh) 2.05 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 2.05 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/FirstStart (gopogh) 2.05 (chart)
Docker_macOS TestImageBuild/serial/BuildWithBuildArg (gopogh) 2.96 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 7.74 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 44.90 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Jun 9, 2023

I think after other containerd related PRs are merged, lets pull upstream on this PR and check the test results

@medyagh medyagh changed the title Check for CNI plugins none: check for CNI plugins Jun 12, 2023
@medyagh medyagh changed the title none: check for CNI plugins bare-metal driver: check for CNI plugins Jun 12, 2023
@medyagh medyagh changed the title bare-metal driver: check for CNI plugins none driver: check for CNI plugins Jun 12, 2023
@medyagh medyagh merged commit 64588b2 into kubernetes:master Jun 12, 2023
@spowelljr spowelljr deleted the checkForCNIPlugins branch June 12, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube fails to start w/ none driver and K8s v1.24+ w/o containernetworking-plugins
4 participants