Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable virtualbox host mounting by default #1646

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Jun 23, 2017

Users can still set up manual mounts through vbox using the vboxmanage
command or GUI. Users can also utilized the built in minikube mount
command.

This is a bit of a hack, since the mounting is attempted in the driver, but it won't work without these extra steps in the image.

Fixes #1645

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2017
@aaron-prindle
Copy link
Contributor

You had mentioned minishift supported passing flags/env vars to the driver. There seems to be one for the mount:
https://github.com/docker/machine/blob/master/drivers/virtualbox/virtualbox.go#L179-L183

@r2d4
Copy link
Contributor Author

r2d4 commented Jun 23, 2017

Looks like theres a config option for that now, I'll update this PR to just set it

@r2d4 r2d4 force-pushed the disable-vbox-mount branch from 4545f8d to 0f135bc Compare June 23, 2017 21:12
@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #1646 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1646      +/-   ##
==========================================
+ Coverage   38.65%   38.68%   +0.03%     
==========================================
  Files          51       51              
  Lines        2667     2670       +3     
==========================================
+ Hits         1031     1033       +2     
- Misses       1455     1456       +1     
  Partials      181      181
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 44.54% <100%> (+0.16%) ⬆️
cmd/minikube/cmd/start.go 16.85% <50%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109fa16...2bf1a3e. Read the comment docs.

@r2d4 r2d4 requested review from alexbrand and removed request for alexbrand June 23, 2017 22:33
@dlorenc
Copy link
Contributor

dlorenc commented Jun 26, 2017

Could we make this a flag? I think probably more users depend on this than we expect, and the mount command isn't quite ready to take over everything yet.

@r2d4 r2d4 force-pushed the disable-vbox-mount branch from 2b07d6e to a78a6c1 Compare June 28, 2017 21:22
Allows users to disable the filesystem mounts created by the xhyve and
virtualbox drivers.
@r2d4 r2d4 force-pushed the disable-vbox-mount branch from a78a6c1 to 2bf1a3e Compare June 28, 2017 21:23
@r2d4
Copy link
Contributor Author

r2d4 commented Jun 28, 2017

I added a new flag which toggles the driver specific mounts for virtualbox and xhyve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants