Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a built-in version of the vmware driver #16687

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Use a built-in version of the vmware driver #16687

merged 1 commit into from
Jun 15, 2023

Conversation

afbjorklund
Copy link
Collaborator

We want to avoid external binaries, for the refactor

Bring it to the main binary, just like with "parallels"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2023
@afbjorklund
Use a built-in version of the vmware driver
67d37b4 
To avoid depending on an external binary
@afbjorklund afbjorklund mentioned this pull request Jun 13, 2023
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jun 13, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 13, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16687) |
+----------------+----------+---------------------+
| minikube start | 52.0s    | 51.6s               |
| enable ingress | 27.6s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 16687) start: 50.9s 51.0s 52.3s 51.9s 51.8s
Times for minikube start: 53.7s 52.2s 52.8s 51.0s 50.4s

Times for minikube ingress: 26.8s 28.2s 28.7s 27.8s 26.7s
Times for minikube (PR 16687) ingress: 27.2s 27.8s 26.7s 27.7s 27.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16687) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 23.8s               |
| enable ingress | 20.8s    | 21.3s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 25.5s 25.2s 22.5s 22.2s
Times for minikube (PR 16687) start: 21.2s 25.4s 24.9s 25.4s 21.9s

Times for minikube ingress: 20.9s 20.8s 20.8s 20.8s 20.8s
Times for minikube (PR 16687) ingress: 21.8s 20.8s 20.8s 20.3s 22.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16687) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 22.8s               |
| enable ingress | 35.1s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 24.2s 22.3s 23.2s 23.3s
Times for minikube (PR 16687) start: 23.7s 23.6s 23.7s 22.8s 20.4s

Times for minikube ingress: 47.3s 32.4s 32.3s 32.3s 31.3s
Times for minikube (PR 16687) ingress: 31.3s 31.3s 31.4s 31.4s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/embed-certs/serial/Stop (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
QEMU_macOS TestFunctional/serial/InvalidService (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/serial/LogsFileCmd (gopogh) 6.45 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 6.94 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 6.94 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit f6a20ae into kubernetes:master Jun 15, 2023
@afbjorklund afbjorklund mentioned this pull request Jul 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @k8s-ci-robot @medyagh @minikube-pr-bot