tunnel: Allow one tunnel per profile

[spowelljr]

Related #15834 & #15834 (comment)

We were only allowing one tunnel globally, but users may want a tunnel per profile which we should allow.

Before:

$ minikube profile list
|---------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|---------|-----------|---------|--------------|------|---------|---------|-------|--------|
| p1      | docker    | docker  | 192.168.49.2 | 8443 | v1.27.3 | Running |     1 |        |
| p2      | docker    | docker  | 192.168.58.2 | 8443 | v1.27.3 | Running |     1 |        |
|---------|-----------|---------|--------------|------|---------|---------|-------|--------|

$ minikube -p p1 tunnel
✅  Tunnel successfully started

📌  NOTE: Please do not close this terminal as this process must stay alive for the tunnel to be accessible ...

$ minikube -p p2 tunnel

💡  Exiting due to TUNNEL_ALREADY_RUNNING: Another tunnel process is already running, terminate the existing instance to start a new one

After:

$ minikube profile list
|---------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|---------|-----------|---------|--------------|------|---------|---------|-------|--------|
| p1      | docker    | docker  | 192.168.49.2 | 8443 | v1.27.3 | Running |     1 |        |
| p2      | docker    | docker  | 192.168.58.2 | 8443 | v1.27.3 | Running |     1 |        |
|---------|-----------|---------|--------------|------|---------|---------|-------|--------|

$ minikube -p p1 tunnel
✅  Tunnel successfully started

📌  NOTE: Please do not close this terminal as this process must stay alive for the tunnel to be accessible ...

$ minikube -p p2 tunnel
✅  Tunnel successfully started

📌  NOTE: Please do not close this terminal as this process must stay alive for the tunnel to be accessible ...

$ minikube -p p1 tunnel

💡  Exiting due to TUNNEL_ALREADY_RUNNING: Another tunnel process is already running, terminate the existing instance to start a new one

[spowelljr]

/ok-to-test

[medyagh]

Good call !!

[medyagh]

/retest-this-please

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16839) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 51.3s               |
| enable ingress | 29.6s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 49.0s 49.3s 51.1s 50.0s 54.6s
Times for minikube (PR 16839) start: 51.7s 53.0s 49.5s 50.4s 51.7s

Times for minikube ingress: 34.3s 28.3s 27.8s 28.2s 29.2s
Times for minikube (PR 16839) ingress: 28.3s 28.3s 29.3s 27.8s 27.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16839) |
+----------------+----------+---------------------+
| minikube start | 24.7s    | 22.9s               |
| enable ingress | 49.2s    | 49.6s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 25.1s 24.2s 25.1s 25.3s
Times for minikube (PR 16839) start: 22.5s 25.3s 21.7s 22.6s 22.2s

Times for minikube ingress: 48.3s 48.9s 49.3s 48.9s 50.3s
Times for minikube (PR 16839) ingress: 49.4s 49.4s 51.3s 49.4s 48.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16839) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 21.5s               |
| enable ingress | 41.1s    | 35.0s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 23.1s 20.7s 22.7s 23.0s
Times for minikube (PR 16839) start: 20.6s 23.3s 23.3s 20.0s 20.2s

Times for minikube (PR 16839) ingress: 31.3s 31.3s 48.4s 31.3s 32.4s
Times for minikube ingress: 31.4s 31.3s 31.4s 31.4s 79.9s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/FreshStart2Nodes (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/AddNode (gopogh)	0.58 (chart)
KVM_Linux	TestMultiNode/serial/CopyFile (gopogh)	0.58 (chart)
KVM_Linux	TestMultiNode/serial/StopNode (gopogh)	0.58 (chart)
KVM_Linux	TestMultiNode/serial/StartAfterStop (gopogh)	11.63 (chart)
QEMU_macOS	TestAddons/Setup (gopogh)	49.04 (chart)

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment