Integration test cleanup #1938
Merged
Integration test cleanup #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
- Coverage 31.35% 30.45% -0.91%
==========================================
Files 75 76 +1
Lines 4557 4692 +135
==========================================
Hits 1429 1429
- Misses 2949 3084 +135
Partials 179 179
Continue to review full report at Codecov.
|
If we choose a random namespace, the test will fail since RBAC permissions will not be set up correctly. This also chooses a randomly generated name, so that if we are running an integration test while another busybox pod is still cleaning up, there are no errors
* Separate start args from args passed to every command. This is so that we can call `minikube logs` and `minikube status` with the proper flags (for the bootstrapper) * Add a NewMinikubeRunner function to make getting a minikube runner easier.
r2d4
force-pushed
the
integration-test-cleanup-
branch
from
27c6495
to
9747484
Compare
|
@aaron-prindle @dlorenc PTAL when you get a chance - this is a blocker for #1903 and #1904 (because of RBAC) |
aaron-prindle
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to the integration tests needed for #1903
Persistence Test: Don't start up busybox pod in random namespace, since there won't be sufficient RBAC permissions created.
Use a randomly generated name for busybox. If the TestFunctional/DNS ends too closely with TestPersistence, it could try to create a busybox pod, while the one from the DNS test hasn't deleted yet. Using a randomly generate name prevents this, but we have to query the name after we create it in TestFunctional/DNS so that we can exec into it afterwards.
Move the kubernetes WaitFor... utils to
pkg/utiland out of the integration tests. I want to use some of them in Kubeadm bootstrapper #1903 and they might be generally useful outside of the integration tests. One of these functions also had to change, since the kubernetes library it used was printing things to stdout.Split up minikube start args from root args. We need to pass certain flags to all commands in the integration tests (verbosity, logtostderr, bootstrapper) which we weren't currently before. Now, all commands will append
-minikube-argsto the command, whilestartwill additionally useminikube-start-args.Add the NewMinikubeRunner helper function to set the flags on the struct correctly. This removes a lot of code.