Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go 1.9 #2113

Merged
merged 2 commits into from
Oct 24, 2017
Merged

upgrade to go 1.9 #2113

merged 2 commits into from
Oct 24, 2017

Conversation

priyawadhwa
Copy link

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2017
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 24, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@r2d4
Copy link
Contributor

r2d4 commented Oct 24, 2017

@minikube-bot add to whitelist

Makefile Outdated
HYPERKIT_BUILD_IMAGE ?= karalabe/xgo-1.8.3
BUILD_IMAGE ?= gcr.io/google_containers/kube-cross:v1.8.3-1
HYPERKIT_BUILD_IMAGE ?= karalabe/xgo-1.9
BUILD_IMAGE ?= gcr.io/google_containers/kube-cross:v1.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how these are actually versioned, but you might want to try these kube-cross tags

$ gcloud container images list-tags gcr.io/google_containers/kube-cross
DIGEST        TAGS             TIMESTAMP
058ef002ff6a  v1.9.1-1         2017-10-16T14:23:55
7de0c648dfc1  v1.8.3-3         2017-10-02T17:09:08
37e2cf0ec470                   2017-10-02T16:38:16
890905b75b63  v1.8.3-2         2017-07-13T15:53:26
bf9d8c19414c  v1.7.6-k8s1.6-0  2017-05-25T11:49:37
9fda5e764ad7  v1.7.6-k8s1.5-0  2017-05-25T10:49:25
762d8f636782  v1.8.3-1         2017-05-25T02:31:12
ac1327a97b1b  v1.8.1-2         2017-05-16T04:30:25
fc8102dcf9ad                   2017-05-16T01:40:27
9805015b6c75  v1.8.1-1         2017-04-17T15:47:40

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also, I just checked and there actually isn't an image in 1.9 for the hyperkit build image, so should we only update the build image or leave them both at 1.8.3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a PR open for 1.9.1 for karalabe/xgo
karalabe/xgo#92

I think its fine to just update the minikube ones (BUILD_IMAGE) for now - those are the ones that might be a little tricky with the vendoring.

There should be no problem with building the hyperkit driver with 1.8 and minikube with 1.9 for a bit.

@priyawadhwa
Copy link
Author

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 24, 2017
@codecov-io
Copy link

Codecov Report

Merging #2113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2113   +/-   ##
=======================================
  Coverage   28.86%   28.86%           
=======================================
  Files          81       81           
  Lines        5307     5307           
=======================================
  Hits         1532     1532           
  Misses       3582     3582           
  Partials      193      193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea31492...404a043. Read the comment docs.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@r2d4 r2d4 merged commit 4d10509 into kubernetes:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants