Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it known that get-k8s-versions is only relevant when using localkube #2204

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Make it known that get-k8s-versions is only relevant when using localkube #2204

merged 1 commit into from
Nov 17, 2017

Conversation

patrikerdes
Copy link
Contributor

Added a reference to localkube in the help text and in the output from
the command.

(Also removed the redundant word "available" and changed the capitalization of Kubernetes.)

Added a reference to localkube in the help text and in the output from
the command.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@patrikerdes
Copy link
Contributor Author

Somewhat related to #2156

@codecov-io
Copy link

Codecov Report

Merging #2204 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2204   +/-   ##
=======================================
  Coverage   27.73%   27.73%           
=======================================
  Files          82       82           
  Lines        5538     5538           
=======================================
  Hits         1536     1536           
  Misses       3806     3806           
  Partials      196      196
Impacted Files Coverage Δ
cmd/minikube/cmd/get_kubernetes_versions.go 40% <ø> (ø) ⬆️
...inikube/kubernetes_versions/kubernetes_versions.go 65.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b9aab...9b3322a. Read the comment docs.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes things a lot clearer during the switch.

@r2d4 r2d4 merged commit 8ee34ac into kubernetes:master Nov 17, 2017
@patrikerdes patrikerdes deleted the get-k8s-versions-help branch November 17, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants