-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache list support #2272
Add cache list support #2272
Conversation
Can one of the admins verify this patch? |
@minikube-bot test this please |
@minikube-bot ok to test |
Hi, @r2d4 Do you mind reviewing this PR? |
cmd/minikube/cmd/cache_list.go
Outdated
|
||
func cacheList(images map[string]interface{}) error { | ||
for imageName := range images { | ||
tmpl, err := template.New("list").Parse(cacheListFormat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this up out of the for loop? It looks like the format here is always a constant, so there's no need to do it in each iteration of the loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new flag to custom format for cache list, for future work, we could extend the CacheListTemplate
to add more image detail, such as below:
var cacheListFormat = "{{.CacheImageName}}:{{.CacheImageTag}}\n"
type CacheListTemplate struct {
CacheImageName string
CacheImageTag string
}
But we need to ensure minikube cache add <image>
use latest
tag to save in config.
This
<Image>
does not have a tag.
For example:
$ minikube cache add redis
$ cat .minikube/config/config.json
{
"WantReportError": true,
"WantReportErrorPrompt": false,
"cache": {
"redis:latest": null
},
"ingress": false
}
cmd/minikube/cmd/cache_list.go
Outdated
"k8s.io/minikube/pkg/minikube/constants" | ||
) | ||
|
||
const cacheListFormat = "- {{.CacheImageName}}\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: do we need the "-" character here? It would make automatic parsing of stdout a little tricker (like if you wanted to use this in a bash for loop, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I ignored this usage scenario, I'll remove this character to bring about this results:
$ minikube cache add redis ubuntu
$ minikube cache delete $(minikube cache list)
cmd/minikube/cmd/config/config.go
Outdated
if err != nil { | ||
return nil, err | ||
} | ||
newImages := make(map[string]interface{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a "slice" of images work instead of a map? It looks like you only set "nil" as the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I'll do it!
This commit added cache list support. Because currently cannot know which images are cached.
For command result as below: