Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker, from 17.06 to 17.09 #2427

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Conversation

afbjorklund
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2018
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Jan 16, 2018

17.12.0 seems to fail horribly, will try with 17.09.0 instead

Error response from daemon: OCI runtime create failed: container_linux.go:296: starting container process caused "process_linux.go:398: container init caused \"rootfs_linux.go:107: jailing process inside rootfs caused \\\"pivot_root invalid argument\\\"\"": unknown

@afbjorklund afbjorklund changed the title Upgrade Docker, from 17.06 to 17.12 Upgrade Docker, from 17.06 to 17.09 Jan 16, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jan 17, 2018

Thanks!

@dlorenc
Copy link
Contributor

dlorenc commented Jan 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, dlorenc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2018
@dlorenc dlorenc merged commit 047be76 into kubernetes:master Jan 17, 2018
@afbjorklund afbjorklund deleted the docker branch January 27, 2018 12:58
@afbjorklund
Copy link
Collaborator Author

The reason that 17.12.0 didn't work was because DOCKER_RAMDISK stopped working in containerd:
moby/moby#35957

It has been fixed in the 18.02 release, so we will be able to upgrade to 18.03.0-ce once it comes out.
Meanwhile, we could upgrade to 17.09.0 to 17.09.1 - and remove the checksum for 17.12.0 perhaps.

@karser
Copy link

karser commented Mar 4, 2018

@afbjorklund Maybe for now it makes sense to upgrade to 17.12.1?

17.12.1-ce (2018-02-27)
- Honor DOCKER_RAMDISK with containerd 1.0 moby/moby#35957

@karser
Copy link

karser commented Mar 5, 2018

I just compiled ISO locally - it seems to be working

sha256 1270dce1bd7e1838d62ae21d2505d87f16efc1d9074645571daaefdfd0c14054  docker-17.12.1-ce.tgz
DOCKER_BIN_VERSION = 17.12.1-ce

@afbjorklund
Copy link
Collaborator Author

@karser : sure, that would work too...

@afbjorklund
Copy link
Collaborator Author

@karser : added a PR, we'll see how it goes..
Docker 18.03 is currently on RC3, I believe ?
So might as well wait for 18.03.1-ce, it seems
(good ole "always wait for Service Pack 1" rule)

@karser
Copy link

karser commented Mar 22, 2018

18.03.0-ce has been released

@afbjorklund
Copy link
Collaborator Author

@karser : and yet, only 17.03 is supported: (by kubeadm)

https://kubernetes.io/docs/setup/independent/install-kubeadm/#installing-docker

On each of your machines, install Docker. Version v1.12 is recommended, but v1.11, v1.13 and 17.03 are known to work as well. Versions 17.06+ might work, but have not yet been tested and verified by the Kubernetes node team.

Think we should rest on 17.12, at least for a month or so ?

https://docs.docker.com/install/#time-based-release-schedule

  • Docker CE Stable releases generally happen quarterly, with patch releases as needed.
  • A given Docker CE Stable release receives patches and updates for one month after the next Docker CE Stable release.

Still cleaning up after the 1.12.6 to 1.13.1 rebase on CentOS...
Upgrading for the sake of upgrading is highly overrated, I think.

@karser
Copy link

karser commented Mar 25, 2018

only 17.03 is supported

Ugh, that's an ancient one

for the sake of upgrading

For me, it's not like that. 17.12 allows to copy a folder and set the ownership in one step, e.g: COPY --chown=user:user . ./

@afbjorklund
Copy link
Collaborator Author

The 17.12.1-ce release should already be the default: cc965e3

But since there hasn't been a new ISO/distro release, you will need to compile your own buildroot...

@r2d4: Maybe it is time to bump the ISO_VERSION to v0.25.2 ?

I guess some people use the minikube docker as their main docker, and thus need newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants