-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding support for s390x #2881
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
/check-cla |
Sorry, I don't think we can support builds for other architectures like this without a CI setup that can run tests. We've discussed this a few times for other architectures: |
@dlorenc Could you provide more details about CI setup? We would like to join CI setup. Please let us know the steps to follow. |
Any update? |
Any updates ? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@@ -0,0 +1,50 @@ | |||
# Copyright 2016 The Kubernetes Authors All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per-architecture YAML files are going to get very painful to maintain. Could this be templatized somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes . I agree, I am finding a way to templatize it. Let me know if you have any suggestion.
We don't yet have a reasonable way of including s390x into the current CI system, but I would be willing to accept this port and list it as experimental for the time being. This situation may chance once our CI environment moves to Prow (#3256) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: salamani If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
63d55dd
to
c64ced1
Compare
This looks great! Do you mind rebasing? I think it's about where we can accept this. |
@tstromberg I am creating new PR as I am getting multiple conflicts during rebase |
These image templates are getting uglier and uglier, think we need another approach here... |
Dupe of #4091 |
PR for #2880