Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adding support for s390x #2881

Closed
wants to merge 4 commits into from

Conversation

salamani
Copy link
Contributor

@salamani salamani commented Jun 7, 2018

PR for #2880

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 7, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 7, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@salamani
Copy link
Contributor Author

salamani commented Jun 7, 2018

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 7, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jun 7, 2018

Sorry, I don't think we can support builds for other architectures like this without a CI setup that can run tests. We've discussed this a few times for other architectures:
#2455

@salamani
Copy link
Contributor Author

salamani commented Jun 8, 2018

@dlorenc Could you provide more details about CI setup? We would like to join CI setup. Please let us know the steps to follow.

@salamani
Copy link
Contributor Author

Any update?

@salamani
Copy link
Contributor Author

Any updates ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2018
@salamani
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2018
@guirish
Copy link

guirish commented Jan 3, 2019

Hi @salamani @dlorenc any updates on this PR w.r.t s390x inclusion in CI ?

@@ -0,0 +1,50 @@
# Copyright 2016 The Kubernetes Authors All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per-architecture YAML files are going to get very painful to maintain. Could this be templatized somehow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes . I agree, I am finding a way to templatize it. Let me know if you have any suggestion.

@tstromberg
Copy link
Contributor

Hi @salamani @dlorenc any updates on this PR w.r.t s390x inclusion in CI ?

We don't yet have a reasonable way of including s390x into the current CI system, but I would be willing to accept this port and list it as experimental for the time being. This situation may chance once our CI environment moves to Prow (#3256)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: salamani
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 20, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2019
@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2019
@tstromberg tstromberg changed the title Adding support for s390x WIP: Adding support for s390x Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2019
@tstromberg
Copy link
Contributor

This looks great! Do you mind rebasing? I think it's about where we can accept this.

@salamani
Copy link
Contributor Author

@tstromberg I am creating new PR as I am getting multiple conflicts during rebase

@afbjorklund
Copy link
Collaborator

These image templates are getting uglier and uglier, think we need another approach here...

@tstromberg
Copy link
Contributor

Dupe of #4091

@tstromberg tstromberg closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants