Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx ingress controller to 0.16.2 #2930

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Update nginx ingress controller to 0.16.2 #2930

merged 1 commit into from
Jun 26, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 24, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aledbf
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

Assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member Author

aledbf commented Jun 25, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2018
@aledbf aledbf changed the title Update nginx ingress controller to 0.16.1 Update nginx ingress controller to 0.16.2 Jun 25, 2018
@aledbf
Copy link
Member Author

aledbf commented Jun 25, 2018

/cancel hold

@aledbf
Copy link
Member Author

aledbf commented Jun 25, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jun 26, 2018

/hold cancel

Is this ready to go in? It looks good to me.

@aledbf
Copy link
Member Author

aledbf commented Jun 26, 2018

Is this ready to go in? It looks good to me.

Yes, this is ready.

@dlorenc dlorenc merged commit 3e267fd into kubernetes:master Jun 26, 2018
@aledbf aledbf deleted the ingress-0.16.1 branch May 4, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @k8s-ci-robot @dlorenc