Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify api server port through CLI fix #2781 #3108

Merged

Conversation

sebcworks
Copy link
Contributor

To solve problem when port 8443 is already in use on host (see issue #2781), add the --apiserver-port CLI option allowing a different API port to be specified (defaults to 8443 which was the original choice).
Update the kubeadm test in order to test this functionnality

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@sebcworks
Copy link
Contributor Author

Last steps of CLA signing done...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 2, 2018
@sebcworks
Copy link
Contributor Author

/assign @dlorenc

@tstromberg
Copy link
Contributor

@minikube-bot - OK to test

@tstromberg
Copy link
Contributor

Your PR looks fine, but I want to take a few days to fix our broken integration tests before I will be able to approve with confidence. Thanks for adding this1

@sebcworks
Copy link
Contributor Author

Great, thanks to you for your work!
I stay tuned in the case I'll have to "fix" this PR, so there is no problem :)

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@simplyviks
Copy link

Hi ,

when is this change going to be merged to master?

regards,
Vikash

@simplyviks
Copy link

@minikube-bot OK to test

when are we going to merge this , do we have a timeline ? Thanks

@tstromberg tstromberg merged commit 7b32547 into kubernetes:master Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebcworks, simplyviks, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants