-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify api server port through CLI fix #2781 #3108
Allow to specify api server port through CLI fix #2781 #3108
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
Last steps of CLA signing done... |
/assign @dlorenc |
@minikube-bot - OK to test |
Your PR looks fine, but I want to take a few days to fix our broken integration tests before I will be able to approve with confidence. Thanks for adding this1 |
Great, thanks to you for your work! |
@minikube-bot OK to test |
Hi , when is this change going to be merged to master? regards, |
when are we going to merge this , do we have a timeline ? Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sebcworks, simplyviks, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To solve problem when port 8443 is already in use on host (see issue #2781), add the
--apiserver-port CLI
option allowing a different API port to be specified (defaults to 8443 which was the original choice).Update the kubeadm test in order to test this functionnality