Fix Windows cache path issues with directory hierarchies and lower-case drive letters #3252
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
|
/assign @jimmidyson |
|
Can you make the PR description more specific? I'd like it to be something usable for release notes generation, and I'm not exactly sure what the behavioral change is. |
|
Sure. I've updated it. Hope that's OK now. Cheers.
|
tstromberg
changed the title
tstromberg
changed the title
tstromberg
added
the
approved
|
@minikube-bot OK to test |
|
@tstromberg I'm wondering what is preventing this from being merged? What's the next step? I'd expected this to be included in one of the previous two minikube releases and am wondering if I'm missing some step that I need to be carrying out? Cheers. |
|
My apologies - We were holding off on merging most PR's until we could be satisfied that our CI system was working appropriately. Will refresh the test results. |
|
@minikube-bot OK to test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlgibbons, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes the issues related to image caching which are noted in #3250. Specifically, image caching fails due to: (1) failing to cache an image with multiple levels in its hierachy e.g. ...\cache\images\gcr.io\k8s-minikube\storage-provisioner_v1.8.1; 2) failing to cache an image when a lowercase drive letter is used in the cache's path.