-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable host DNS resolution in virtualbox driver by default #3453
Conversation
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clocklear If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @balopat |
This Travis failure seems unrelated to my PR. |
@balopat do you mind taking a look a this? |
@minikube-bot OK to test |
Thanks @tstromberg; these failures don't look related to my PR, can you confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
I'm puzzled by the travis issue, I restarted it and it passed.
|
Thanks guys! |
I'm pretty certain, while this is actually something I personally want, it seems to be causing breakage for me. It doesn't seem to even be using my host's DNS settings either. I can say for certain, I was previously able to query some hosts fine, but now it's failing. I run my own DNS server on my network as well, and on 0.32 I don't even see the queries in the logs. After going to 0.31, it seems to be actually using my host's DNS again, since the queries in minikube do show up on my DNS servers logs. |
Addresses #3451; as such, there is more context over there.
The default settings for the VirtualBox machine enables
DNSProxy
and disablesHostDNSResolver
. I'd like to propose reversing these settings. If the host is used for DNS resolution, we can enable the kubernetes cluster to resolve registry URLs likeregistry.kube-system.svc.cluster.local:80
, assuming that the host has properly configured acluster.local
resolver that routes traffic to the minikube network.This should not cause any backwards-incompatible issues (so far as I can tell) and should be a drop-in replacement for what folks are already using. I am, of course, open to putting this behind some sort of runtime configuration flag.