Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ipvlan kernel module #3510

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Enable ipvlan kernel module #3510

merged 1 commit into from
Jan 14, 2019

Conversation

brb
Copy link
Contributor

@brb brb commented Jan 7, 2019 •
edited
Loading

This makes it possible to use ipvlan CNI plugins in minikube.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

Do you mind adding a "why" into the pull request description? For future code archeologists.

@brb brb force-pushed the enable_ipvlan_module branch from 027852f to 769cbe5 Compare January 9, 2019 07:49
@brb
Copy link
Contributor Author

brb commented Jan 9, 2019

@tstromberg Sure, updated.

@brb
Enable ipvlan kernel module
4792a62 
This makes it possible to use ipvlan CNI plugins in minikube.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the enable_ipvlan_module branch from 769cbe5 to 4792a62 Compare January 9, 2019 13:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brb, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019
@tstromberg tstromberg merged commit d8f2e99 into kubernetes:master Jan 14, 2019
@brb
Copy link
Contributor Author

brb commented Feb 12, 2019

@tstromberg Hmm, it seems that the iso image for the latest minikube (v0.33.1) hasn't been rebuilt, as the ipvlan module is missing:

$ zgrep IPVLAN /proc/config.gz
$ echo $?
1
$ uname -a
Linux minikube 4.15.0 #1 SMP Fri Jan 18 22:39:33 UTC 2019 x86_64 GNU/Linux

and

> minikube version
minikube version: v0.33.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brb @minikube-bot @tstromberg @k8s-ci-robot