Add new VMware unified driver to supported list #2

[frapposelli]

This is a follow up from #2606 as the original fork was removed and unable to update the PR

This PR adds the new VMware unified driver to the supported list, the driver now supports Fusion and Workstation across Windows, Linux and macOS.

A deprecation note has been added for the bundled vmwarefusion driver.

Ref: #2118 #2526 machine-drivers/discussion#5 machine-drivers/docker-machine-driver-vmware#1

Fixes: machine-drivers/docker-machine-driver-vmware#1 #2118

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frapposelli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

If they are not already assigned, you can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[frapposelli]

/assign @tstromberg

[tstromberg]

Any idea what is pulling in this dependency? It seems unusual to include a github client into minikube.

[frapposelli]

it looked weird to me as well, and I honestly don't know where it's coming from.

Before submitting the PR I double checked and it is not coming from our github.com/machine-drivers/docker-machine-driver-vmware import, so I assumed that the dep ensure command pulled a dependency coming from somewhere else in the minikube codebase.

[tstromberg]

I can confirm that running dep ensure causes these to appear on my end. Strange!

[tstromberg]

@minikube-bot OK to test

[mlebrun]

@frapposelli I updated Minikube to the 0.33.1 release to try out this driver and it seems like VMware Tools isn't installed? Which then makes Shared Folder support a bit unstable/unusable. I wasn't sure if there's anything I can do to get better Shared Folder support from Fusion (OSX) within Minikube? (I realize you're not full time Minikube maintainer, seeing if you have any input!) The minikube --mount method isn't that great when mounting a lot of files (or maybe just seems better suited to smaller projects?) so that's why I'm hoping for better Shared Folder support. Wasn't sure if you give any insight into that or not?

[mlebrun]

Seeing this which I just noticed when running verbose logs on minikube start:

(minikube) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser addSharedFolder /Users/{user}/.minikube/machines/minikube/minikube.vmx Users /Users
(minikube) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser runScriptInGuest /Users/{user}/.minikube/machines/minikube/minikube.vmx /bin/sh [ ! -d /hosthome ]&& sudo mkdir /hosthome; sudo mount --bind /mnt/hgfs//hosthome /hosthome || [ -f /usr/local/bin/vmhgfs-fuse ]&& sudo /usr/local/bin/vmhgfs-fuse -o allow_other .host:/Users /hosthome || sudo mount -t vmhgfs -o uid=$(id -u),gid=$(id -g) .host:/Users /hosthome
(minikube) DBG | Guest program exited with non-zero exit code: 1