Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3253, improve kubernetes-version error string #3596

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

flyingcircle
Copy link
Contributor

Since the kubernetes version is used in creating the URLs to grab binaries, not including the 'v' would require adding it back in certain places. Simply adding a better error message.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flyingcircle
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

tstromberg commented Mar 21, 2019

Any chance of signing the CLA so that this could be merged?

📝 Instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement

@flyingcircle
Copy link
Contributor Author

I signed it

@tstromberg
Copy link
Contributor

The bot isn't noticing the CLA signing, and says "commit missing GitHub user"

c9d79f1 says the commit is by "Jeremy Hamilton" - which is presumably you, but perhaps with an e-mail address that doesn't match what GitHub has?

I found this article about the problem: https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user

Do you mind checking it out? My apologies for the CLA headache.

@flyingcircle
Copy link
Contributor Author

I've switched my email. I'll see if that fixes it (primary/secondary github email?). But everything matches.

@tstromberg
Copy link
Contributor

c9d79f1 still says "Jeremy Hamilton" instead of "flyingcircle", so the CLA checker is still failing :(

# This is the 1st commit message:

Issue kubernetes#3253, improve kubernetes-version error string

# This is the commit message kubernetes#2:

Issue kubernetes#3253, improve kubernetes-version error string
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 22, 2019
@flyingcircle
Copy link
Contributor Author

Alright that took far too long, just ended up having to rebase, and edit my local repo's commit history. But it all looks good now.

@tstromberg tstromberg merged commit aec8c78 into kubernetes:master Mar 26, 2019
@tstromberg
Copy link
Contributor

Thanks for seeing this one through! My apologies for the CLA being so difficult to get sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants