Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to fedora-29 #3607

Merged
merged 2 commits into from
Jan 30, 2019
Merged

updated to fedora-29 #3607

merged 2 commits into from
Jan 30, 2019

Conversation

kauedg
Copy link
Contributor

@kauedg kauedg commented Jan 30, 2019

updated toolbox reference to fedora-29. Closing issues #2889 #3058

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2019
@kauedg
Copy link
Contributor Author

kauedg commented Jan 30, 2019

$TOOLBOX_DOCKER_ARCHIVE variable removed as Fedora does not maintain the toolbox archive anymore

tstromberg
tstromberg approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making these changes! I really appreciate it.

@tstromberg tstromberg added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kauedg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg merged commit 75ea1af into kubernetes:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kauedg @minikube-bot @k8s-ci-robot @tstromberg