Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libvirtd #3711

Merged
merged 5 commits into from
Feb 27, 2019
Merged

update libvirtd #3711

merged 5 commits into from
Feb 27, 2019

Conversation

Expire0
Copy link
Contributor

@Expire0 Expire0 commented Feb 17, 2019

libvirtd must be started before you run minikube. Failure to do so will result in the below error
Failed to connect socket to '/var/run/libvirt/libvirt-sock'
I believe this should be noted in the documentation to assist other users.
Added lines 40-43

libvirtd must be started before you run minikube. Failure to do so will result in the below error 
Failed to connect socket to '/var/run/libvirt/libvirt-sock'
I believe this should be noted in the documentation to assist other users.  
Added lines 40-43
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 17, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2019
@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 17, 2019

This probably only applies to the KVM drivers ("kvm" and "kvm2") on Linux ? Not VirtualBox etc.

Also, I believe the daemon is started automatically on Debian and derivates like Ubuntu.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 17, 2019
@Expire0
Copy link
Contributor Author

Expire0 commented Feb 17, 2019

Also, I believe the daemon is started automatically on Debian and derivates like Ubuntu.

I tested this on Ubuntu 18.04 and it does start automatically. The issue may only be related to Centos 7/Fedora 29 /Redhat 7

@afbjorklund
Copy link
Collaborator

On other hand, it doesn't really hurt to start it again... But the instructions should be up with the rest of the hypervisor install (like adding yourself to the root-equivalent libvirtd group), rather than with the driver:

To install the KVM2 driver, first install and configure the prereqs:

HERE: Make sure that the libvirt daemon actually started, after installation

Then you will need to add yourself to libvirt group (older distributions may use libvirtd instead)

Then to join the group with your current user session:

Now install the driver:

move the systemctl start closer to the install steps 
libvirtd.service
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2019
@Expire0
Copy link
Contributor Author

Expire0 commented Feb 21, 2019

I moved the instructions under the install as you suggested. Good idea

Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some minor changes

docs/drivers.md Outdated Show resolved Hide resolved
docs/drivers.md Outdated
```
Enable,start, and verify the libvirtd service has started.
```shell
systemctl enable libvirtd.service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally one wants to use "sudo" here, to avoid that annoying popup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion. I found that i needed to be root to run through the documentation . If that's the case then sudo is not needed. I updated the doc to include sudo just in case

docs/drivers.md Outdated
```shell
systemctl enable libvirtd.service
systemctl start libvirtd.service
systemctl status libvirtd.service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status seems a bit paranoid ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just a little. I think it may be good to check before moving to the next step.

corrected lines 62 to 78 and added sudo to the systemctl command
Copy link
Contributor Author

@Expire0 Expire0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the document to include sudo before systemctl. Good idea

add some extra ticks on line 24.
Copy link
Contributor Author

@Expire0 Expire0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the extra ticks on line 24

@afbjorklund
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, Expire0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8d6a45e into kubernetes:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants