-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libvirtd #3711
update libvirtd #3711
Conversation
libvirtd must be started before you run minikube. Failure to do so will result in the below error Failed to connect socket to '/var/run/libvirt/libvirt-sock' I believe this should be noted in the documentation to assist other users. Added lines 40-43
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
Also, I believe the daemon is started automatically on Debian and derivates like Ubuntu. |
I tested this on Ubuntu 18.04 and it does start automatically. The issue may only be related to Centos 7/Fedora 29 /Redhat 7 |
On other hand, it doesn't really hurt to start it again... But the instructions should be up with the rest of the hypervisor install (like adding yourself to the root-equivalent
HERE: Make sure that the libvirt daemon actually started, after installation
|
move the systemctl start closer to the install steps libvirtd.service
I moved the instructions under the install as you suggested. Good idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just some minor changes
docs/drivers.md
Outdated
``` | ||
Enable,start, and verify the libvirtd service has started. | ||
```shell | ||
systemctl enable libvirtd.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally one wants to use "sudo" here, to avoid that annoying popup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion. I found that i needed to be root to run through the documentation . If that's the case then sudo is not needed. I updated the doc to include sudo just in case
docs/drivers.md
Outdated
```shell | ||
systemctl enable libvirtd.service | ||
systemctl start libvirtd.service | ||
systemctl status libvirtd.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status seems a bit paranoid ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah just a little. I think it may be good to check before moving to the next step.
corrected lines 62 to 78 and added sudo to the systemctl command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the document to include sudo before systemctl. Good idea
add some extra ticks on line 24.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the extra ticks on line 24
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, Expire0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
libvirtd must be started before you run minikube. Failure to do so will result in the below error
Failed to connect socket to '/var/run/libvirt/libvirt-sock'
I believe this should be noted in the documentation to assist other users.
Added lines 40-43