Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tap and vhost-net in minikube iso #3758

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Enable tap and vhost-net in minikube iso #3758

merged 1 commit into from
Mar 6, 2019

Conversation

karmab
Copy link
Contributor

@karmab karmab commented Feb 26, 2019

These are required to use kubevirt within minikube.

Closes #3762

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2019
@karmab
Copy link
Contributor Author

karmab commented Feb 26, 2019

/assign @balopat

@afbjorklund
Copy link
Collaborator

Please open an issue describing why this is needed

@afbjorklund
Copy link
Collaborator

@karmab : Thanks!

@tstromberg
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karmab, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@tstromberg tstromberg merged commit cc71bf9 into kubernetes:master Mar 6, 2019
@karmab karmab deleted the vhost_net_support branch March 6, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants