-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reliability of kube-proxy configmap updates (retry, block until pods are up) #3774
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, worked here!
⌛ Waiting for pods: apiserver proxy etcd dns controller scheduler storage-provisioner addon-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Today I ran into "waiting for kube-proxy to be up for configmap update", and noticed that kube-proxy came up ~50 seconds after the current timeout, so I extended the timeout by 3 minutes.
I then began on a mission to fix other related bugs by making sure that StartCluster/RestartCluster block until all of the pods are healthy. While this may extend start times on broken configs somewhat, it should result in less flakiness overall.
Example start:
Example restart:
Issues this PR may affect: #3031 #2726 #3765 #3511