Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minikube logs for other container runtimes #3780

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

afbjorklund
Copy link
Collaborator

It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.

Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.

Fixes #3744

@afbjorklund afbjorklund requested a review from tstromberg March 1, 2019 19:47
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2019
@k8s-ci-robot k8s-ci-robot requested a review from dlorenc March 1, 2019 19:47
@afbjorklund
Copy link
Collaborator Author

Wonder why we put the error message in the command to run ? Interesting choice...

I0224 18:31:09.379857    5604 ssh_runner.go:137] Run with output: No container was found matching "k8s_coredns_coredns"
I0224 18:31:09.382572    5604 utils.go:224] ! bash: No: command not found
E0224 18:31:09.383071    5604 logs.go:120] failed: Process exited with status 127

Notice the "No: command not found", as in "No container was found" :-)

It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.

Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.
@tstromberg
Copy link
Contributor

/approve /lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg merged commit 794bc6c into kubernetes:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRI: minikube logs doesn't work with cri-o runtime
3 participants