Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize ASCII prefix for info, warning, and error messages #4162

Merged
merged 6 commits into from
May 7, 2019
Merged

Standardize ASCII prefix for info, warning, and error messages #4162

merged 6 commits into from
May 7, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Apr 26, 2019 •
edited
Loading

Example output:

* minikube v1.0.1 on linux (amd64)
* Creating kvm2 VM (CPUs=2, Memory=2048MB, Disk=20000MB) ...
* Configuring environment for Kubernetes v1.14.1 on Docker 
* Pulling images ...
* Launching Kubernetes ... 
* Waiting for: apiserver proxy etcd scheduler controller dns

See #4157

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2019
@sharifelgamal
Copy link
Collaborator

Looks like you need to fix a couple of our unit tests to account for these changes.

@tstromberg tstromberg changed the title Standardize ASCII prefixes WIP: Standardize ASCII prefixes Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2019
@tstromberg
Copy link
Contributor Author

Thanks! Once I get some feedback on what styles folks prefer, I'll update this PR to match the top votes:

https://forms.gle/KjFG9ahgqURNr6k78

@tstromberg
Copy link
Contributor Author

The polling appears to have steered away from dashes as a prefix, so I've updated this PR to match, with tests.

@tstromberg tstromberg closed this May 2, 2019
@tstromberg tstromberg reopened this May 2, 2019
@tstromberg tstromberg changed the title WIP: Standardize ASCII prefixes Standardize ASCII output to use ">" as a bullet point May 2, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2019
@tstromberg tstromberg changed the title Standardize ASCII output to use ">" as a bullet point WIP: Standardize ASCII output to use ">" as a bullet point May 2, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2019
@tstromberg
Copy link
Contributor Author

The tests need a little cleanup before this can be merged.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2019
@tstromberg tstromberg changed the title WIP: Standardize ASCII output to use ">" as a bullet point WIP: Standardize ASCII output May 3, 2019
@tstromberg tstromberg changed the title WIP: Standardize ASCII output WIP: Standardize ASCII output prefixes May 3, 2019
@tstromberg tstromberg changed the title WIP: Standardize ASCII output prefixes Standardize the ASCII output prefix for info, warning, and error messages May 3, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2019
@tstromberg tstromberg changed the title Standardize the ASCII output prefix for info, warning, and error messages Standardize ASCII prefix for info, warning, and error messages May 3, 2019
@tstromberg
Copy link
Contributor Author

PTAL - it seems the asterisks won the votes in the end. Not my personal favorite choice, but it's at least a choice to move forwards with =)

@sharifelgamal
Copy link
Collaborator

LGTM, can you update the PR description with a new sample output?

@sharifelgamal
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2cd5336 into kubernetes:master May 7, 2019
@tstromberg tstromberg mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

@sharifelgamal sharifelgamal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstromberg @sharifelgamal @k8s-ci-robot