Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stale err_map entry which broke TestFromError/VBOX_BLOCKED #4215

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix stale err_map entry which broke TestFromError/VBOX_BLOCKED #4215

merged 1 commit into from
May 6, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented May 6, 2019 •
edited
Loading

The key was renamed and the list sorted, but I accidentally left the old entry in here. This fixes:

    --- FAIL: TestFromError/VBOX_BLOCKED (0.00s)                     
        problem_test.go:52: FromError("Result Code: NS_ERROR_FAILURE (0x80004005)")=VBOX_BLOCKED_LOADING, want VBOX_BLOCKED
FAIL

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2019
@tstromberg tstromberg changed the title Remove duplicate err_map entry breaking tests Fix stale err_map entry which broke TestFromError/VBOX_BLOCKED May 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@tstromberg tstromberg merged commit fe3f7a0 into kubernetes:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat Awaiting requested review from balopat

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstromberg @k8s-ci-robot