-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate kvm network exists #4308
Validate kvm network exists #4308
Conversation
Welcome @josedonizetti! |
Hi @josedonizetti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Thank you for contributing this! Having validation like this will definitely help minikube users debug what's going on. It's a great step forward to a world where minikube is able to fix kvm network configuration errors. |
Minikube isn't validating if the kvm network exists, in the case the
default
one isn't created or the user passed a custom one--kvm-network
and it doesn't exist the code will go on creating the PrivateNetwork to only raise an error at the end. This PR adds validation for this case, so it fails fast instead of moving on with other resources creation.