Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch kubectl current-context on profile change #4504

Merged
merged 5 commits into from
Jun 18, 2019

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jun 16, 2019

closes #4503

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2019
@medyagh medyagh changed the title set kubectl current context on profile change Change kubectl current-context on profile change Jun 16, 2019
@medyagh medyagh changed the title Change kubectl current-context on profile change Switch kubectl current-context on profile change Jun 16, 2019
@medyagh
Copy link
Member Author

medyagh commented Jun 16, 2019

@minikube-bot OK to test

@sharifelgamal sharifelgamal merged commit 35bbace into kubernetes:master Jun 18, 2019
@medyagh medyagh deleted the profile_context_4503 branch November 6, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: setting minikube profile should set k8s current context .
3 participants