-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warn if kvm driver version is old #4676
Add warn if kvm driver version is old #4676
Conversation
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ab260b8
to
8a4bf13
Compare
@medyagh Let me know what you think about the changes. I've added a constant to the kvm documentation, we could start enforcing it everywhere we link to the documentation, that way if we need to change one day, it's a single change. I'll try to simplify the documentation now. Although I'm intrigued the PR #4681 make this one unnecessary. |
I think this PR could be used to detect the too old KVM drivers that we want to enforce the upgrade ( before the user waits a few minutes till the error happen) if we know the kvm driver is too old. we should end gracefuly without error. the other PR is good when minikube crashes with an error. it is meant as an after-happened handling, so we have less support ticket. so this is PR is still helpful and needed to detect sooner |
b2e409e
to
4f3a83c
Compare
@medyagh I've added an upgrade section to the KVM documentation. I know you mentioned we had too many |
1136529
to
bbdb1a7
Compare
bbdb1a7
to
4cce597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
@minikube-bot OK to test |
issue: #4658