Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete kubeconfig context when a machine has been deleted #4678

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Delete kubeconfig context when a machine has been deleted #4678

merged 1 commit into from
Jul 5, 2019

Conversation

kairen
Copy link
Contributor

@kairen kairen commented Jul 4, 2019

The commit added a new function for deleting the kubeconfig context when a machine has been deleted.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

Hi @kairen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kairen
To complete the pull request process, please assign balopat
You can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jul 4, 2019

@minikube-bot OK to test

medyagh
medyagh requested changes Jul 4, 2019
View reviewed changes
pkg/util/kubeconfig.go Outdated Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Jul 4, 2019 •
edited
Loading

Thank you so much for this contribution ! this makes minikube much more stable and user-friendly ! I tested it and it works thank you very much @kairen

@kairen kairen changed the title Delete kubeconfig when a machine has been deleted Delete kubeconfig context when a machine has been deleted Jul 4, 2019
josedonizetti
josedonizetti reviewed Jul 4, 2019
View reviewed changes
pkg/util/kubeconfig.go
func DeleteKubeConfigContext(kubeCfgPath, machineName string) error {
kcfg, err := ReadConfigOrNew(kubeCfgPath)
if err != nil {
return errors.Wrap(err, "Error getting kubeconfig status")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to start enforcing errors not to be capitalized? We currently have both in the minikube codebase, but I think we could start using the same pattern everywhere. WDYT? @kairen @medyagh

@RA489
Copy link

RA489 commented Jul 5, 2019

@minikube-bot OK to test

@medyagh medyagh merged commit 11f8c61 into kubernetes:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti left review comments

@medyagh medyagh medyagh approved these changes

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kairen @minikube-bot @k8s-ci-robot @medyagh @RA489 @josedonizetti