Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove heapster (needs rebase) #5038

Closed
wants to merge 1 commit into from
Closed

WIP: remove heapster (needs rebase) #5038

wants to merge 1 commit into from

Conversation

rusik69
Copy link
Contributor

@rusik69 rusik69 commented Aug 10, 2019 •
edited
Loading

This pr removes heapster from minikube
Fixes #5017

@k8s-ci-robot
Copy link
Contributor

Welcome @Loqutus!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Loqutus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: loqutus
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 10, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rusik69
Copy link
Contributor Author

rusik69 commented Aug 10, 2019

/assign @tstromberg

@RA489
Copy link

RA489 commented Aug 11, 2019

@minikube-bot OK to test

Zyqsempai
Zyqsempai reviewed Aug 13, 2019
View reviewed changes
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the conflicts.

@medyagh medyagh changed the title remove heapster WIP: remove heapster (needs rebase) Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2019
@k8s-ci-robot
Copy link
Contributor

@Loqutus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2019
@rajalokan
Copy link
Contributor

/assign rajalokan

@rajalokan
Copy link
Contributor

rajalokan commented Sep 2, 2019 •
edited
Loading

I've created a separate PR with rebased changes here at #5243. Wasn't sure how to contribute to previous branch and use this same PR.

@sharifelgamal
Copy link
Collaborator

Closing this in favor of #5243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zyqsempai Zyqsempai Zyqsempai left review comments

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees

@tstromberg tstromberg

@rajalokan rajalokan

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove heapster addon - it's retired.
8 participants
@rusik69 @k8s-ci-robot @minikube-bot @RA489 @rajalokan @sharifelgamal @Zyqsempai @tstromberg