-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes image repository flags when using CRI-O and containerd runtime #5447
Fixes image repository flags when using CRI-O and containerd runtime #5447
Conversation
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laozc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Travis tests have failedHey @laozc, 1st Buildmake test
TravisBuddy Request Identifier: 82a69b10-dee3-11e9-ad93-37b42dc0d4f9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for quickly making a fix for this issue. Just one minor request and a future suggestion for an API improvement.
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Verified on both Windows/Hyper-V and Darwin/Virtualbox with docker/CRI-O/containerd |
Hey @laozc, TravisBuddy Request Identifier: 856728b0-dff6-11e9-a161-570cf9dcad8d |
/ok-to-test |
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Travis tests have failedHey @laozc, 1st Buildmake test
TravisBuddy Request Identifier: 8c7c74c0-e1a9-11e9-a6b9-35e0da372496 |
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
I'm a bit confused by the test results. It still feels like something may be broken here:
|
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2557373
to
f43690c
Compare
Travis tests have failedHey @laozc, 1st Buildmake test
TravisBuddy Request Identifier: 74381c90-e256-11e9-8d2a-9fae2038ad51 |
My bad. Had the storage-provisioner in the wrong registry. |
Thank you! |
Image repository related flags do not work with CRI-O or containerd runtime.
This PR fixed the issue.
Close: #5434