Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP/UDP ingress tutorial #5517

Merged

Conversation

woodcockjosh
Copy link
Contributor

A tutorial on how to configure ingress TCP and UDP services

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @woodcockjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: woodcockjosh
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@woodcockjosh
Copy link
Contributor Author

Resolves #2840

@woodcockjosh
Copy link
Contributor Author

1 open issue kubernetes/ingress-nginx#4626

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #5517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5517   +/-   ##
=======================================
  Coverage   36.57%   36.57%           
=======================================
  Files         102      102           
  Lines        7320     7320           
=======================================
  Hits         2677     2677           
  Misses       4292     4292           
  Partials      351      351

@woodcockjosh
Copy link
Contributor Author

Issue in nginx project kubernetes/ingress-nginx#4626 closed in favor of #5518

@woodcockjosh woodcockjosh force-pushed the add-tcp-udp-ingress-tutorial branch from 6c88ec6 to e815f44 Compare October 1, 2019 20:15
@woodcockjosh
Copy link
Contributor Author

/assign @RA489

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved w/ minor changes requested.

site/content/en/docs/Tutorials/nginx_tcp_udp_ingress.md Outdated Show resolved Hide resolved
site/content/en/docs/Tutorials/nginx_tcp_udp_ingress.md Outdated Show resolved Hide resolved
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent !

@medyagh medyagh merged commit 3aa542c into kubernetes:master Oct 1, 2019
@woodcockjosh woodcockjosh deleted the add-tcp-udp-ingress-tutorial branch October 1, 2019 21:35
@woodcockjosh
Copy link
Contributor Author

woodcockjosh commented Oct 11, 2019

Related to #1701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants