-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TCP/UDP ingress tutorial #5517
Add TCP/UDP ingress tutorial #5517
Conversation
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Resolves #2840 |
1 open issue kubernetes/ingress-nginx#4626 |
Codecov Report
@@ Coverage Diff @@
## master #5517 +/- ##
=======================================
Coverage 36.57% 36.57%
=======================================
Files 102 102
Lines 7320 7320
=======================================
Hits 2677 2677
Misses 4292 4292
Partials 351 351 |
Issue in nginx project kubernetes/ingress-nginx#4626 closed in favor of #5518 |
6c88ec6
to
e815f44
Compare
/assign @RA489 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved w/ minor changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent !
…in the same minikube instance
Related to #1701 |
A tutorial on how to configure ingress TCP and UDP services