Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance and security enhancement for ingress-dns addon #5614

Conversation

woodcockjosh
Copy link
Contributor

This is a performance and security enhancement for the ingress-dns addon.

  1. Resolves issue where ingress-dns pod is evicted when tcp connection cannot be established by ingress nginx controller
  2. Removes cluster-admin role for ingress-dns addon pod
  3. Removes use of ingress-nginx as passthrough
  4. Ingress dns pod uses host network and binds only to Pod IP / Node IP rather than 0.0.0.0
  5. Tcp routing removed as it is not used
  6. Pod IP / Node IP is used as minikube IP which is the same when pod is using host network rather than querying the cluster IP

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @woodcockjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: woodcockjosh
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #5614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5614   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files         102      102           
  Lines        7369     7369           
=======================================
  Hits         2719     2719           
  Misses       4297     4297           
  Partials      353      353
Impacted Files Coverage Δ
pkg/minikube/assets/addons.go 36.66% <ø> (ø) ⬆️

@woodcockjosh
Copy link
Contributor Author

/assign @medyagh

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@sharifelgamal sharifelgamal merged commit b229f66 into kubernetes:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants