Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove opening browser and just return url(s) #5718

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Refactor to remove opening browser and just return url(s) #5718

merged 1 commit into from
Oct 29, 2019

Commits on Oct 29, 2019

  1. Add boolean to disable opening browser during test 

    The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.

The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
    @nanikjava
    nanikjava committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    994d093 View commit details
    Browse the repository at this point in the history