-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health check previously configured driver & exit if not installed #5840
Health check previously configured driver & exit if not installed #5840
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5840 +/- ##
==========================================
+ Coverage 36.49% 36.55% +0.05%
==========================================
Files 110 110
Lines 8124 8141 +17
==========================================
+ Hits 2965 2976 +11
- Misses 4770 4776 +6
Partials 389 389
|
/ok-to-test |
Error: running mkcmp: exit status 1 |
Error: building minikube at head: updating minikube master branch: running [git pull origin master] in /home/performance-monitor/minikube: |
All Times Minikube (PR 5840): [ 195.384340 185.791113 182.379482] Average Minikube (PR 5840): 187.851645 Averages Time Per Log
|
All Times minikube: [ 175.775262 196.723275 182.969365] Average minikube: 185.155968 Averages Time Per Log
|
Currently we warn about unhealthy drivers only if specified via --vm-driver.
This PR extends that health check to the case where we determine which driver from an existing profile. It also displays what alternative drivers are available, even when a driver is explicitly specified.
Old behavior
New behavior
Fixes #5838 #5821