Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check previously configured driver & exit if not installed #5840

Merged
merged 7 commits into from
Nov 11, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Nov 6, 2019

Currently we warn about unhealthy drivers only if specified via --vm-driver.

This PR extends that health check to the case where we determine which driver from an existing profile. It also displays what alternative drivers are available, even when a driver is explicitly specified.

Old behavior

😄  minikube v1.5.2 on Debian rodete
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.
🔄  Retriable failure: Error getting state for host: VBoxManage not found. Make sure VirtualBox is installed and VBoxManage is in the path
⚠️  Unable to get the status of the minikube cluster.
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.
🔄  Retriable failure: Error getting state for host: VBoxManage not found. Make sure VirtualBox is installed and VBoxManage is in the path
⚠️  Unable to get the status of the minikube cluster.
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.
<retry loop>

New behavior

😄  minikube v1.5.2 on Debian rodete
✨  Selecting 'virtualbox' driver from existing profile (alternates: [kvm2 none])

⚠️  'virtualbox' driver reported an issue: unable to find VBoxManage in $PATH
💡  Suggestion: Install VirtualBox
📘  Documentation: https://minikube.sigs.k8s.io/docs/reference/drivers/virtualbox/

💣  virtualbox does not appear to be installed, but is specified by an existing profile. Please run 'minikube delete' or install virtualbox
<exit!>

Fixes #5838 #5821

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #5840 into master will increase coverage by 0.05%.
The diff coverage is 31.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5840      +/-   ##
==========================================
+ Coverage   36.49%   36.55%   +0.05%     
==========================================
  Files         110      110              
  Lines        8124     8141      +17     
==========================================
+ Hits         2965     2976      +11     
- Misses       4770     4776       +6     
  Partials      389      389
Impacted Files Coverage Δ
pkg/minikube/registry/registry.go 100% <ø> (ø) ⬆️
cmd/minikube/cmd/start.go 19.56% <0%> (-0.21%) ⬇️
pkg/minikube/registry/global.go 86.66% <100%> (+12.59%) ⬆️
pkg/minikube/driver/driver.go 92.59% <85.71%> (-3.16%) ⬇️

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 6, 2019
@minikube-bot
Copy link
Collaborator

Error: running mkcmp: exit status 1

@minikube-bot
Copy link
Collaborator

Error: building minikube at head: updating minikube master branch: running [git pull origin master] in /home/performance-monitor/minikube:
From https://github.com/kubernetes/minikube

  • branch master -> FETCH_HEAD
    error: Your local changes to the following files would be overwritten by merge:
    go.mod
    Please commit your changes or stash them before you merge.
    Aborting
    Updating 9de78fd..f773c4b
    : exit status 1

@minikube-bot
Copy link
Collaborator

All Times Minikube (PR 5840): [ 195.384340 185.791113 182.379482]
All Times minikube: [ 176.580031 176.506973 176.930368]

Average Minikube (PR 5840): 187.851645
Average minikube: 176.672457

Averages Time Per Log

+------------------------+-----------+--------------------+
|          LOG           | MINIKUBE  | MINIKUBE (PR 5840) |
+------------------------+-----------+--------------------+
| minikube v             |  0.315525 |           0.307227 |
| Creating kvm2          | 39.329364 |          38.074358 |
| Preparing Kubernetes   | 53.184384 |          52.977926 |
| Pulling images         |  2.937444 |           3.054512 |
| Launching Kubernetes   | 20.185108 |          19.341825 |
| Waiting for: apiserver | 60.720632 |          74.052914 |
+------------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 175.775262 196.723275 182.969365]
All Times Minikube (PR 5840): [ 187.199634 169.343577 187.137658]

Average minikube: 185.155968
Average Minikube (PR 5840): 181.226956

Averages Time Per Log

+------------------------+-----------+--------------------+
|          LOG           | MINIKUBE  | MINIKUBE (PR 5840) |
+------------------------+-----------+--------------------+
| minikube v             |  0.334295 |           0.301561 |
| Creating kvm2          | 38.094644 |          37.904998 |
| Preparing Kubernetes   | 53.293536 |          52.360820 |
| Pulling images         |  3.045179 |           2.897449 |
| Launching Kubernetes   | 19.663534 |          20.827511 |
| Waiting for: apiserver | 70.724781 |          66.891333 |
+------------------------+-----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad start experience with existing config for a nonexistent hypervisor
5 participants