-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance analysis packages to minikube ISO #5942
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5942 +/- ##
=======================================
Coverage 36.18% 36.18%
=======================================
Files 110 110
Lines 8214 8214
=======================================
Hits 2972 2972
Misses 4851 4851
Partials 391 391 |
which includes iostat, pidstat, and other performance tools. Ref: https://git.busybox.net/buildroot/tree/package/sysstat/Config.in?id=3bbf1c2ea6140d8b288b0af5b1a9c3a1aa92edad
/ok-to-test |
All Times minikube: [ 149.748629 149.672289 147.801738] Average minikube: 149.074219 Averages Time Per Log
|
All Times minikube: [ 146.488917 143.049999 145.451923] Average minikube: 144.996946 Averages Time Per Log
|
@priyawadhwa: Do we really need to add |
another package
e9db89d
to
8ee34b3
Compare
@afbjorklund @medyagh python was included as a dependency of iotop, but actually it seems that iotop is installed by another package and seems to work fine. I've removed |
All Times minikube: [ 142.352473 144.481445 140.232455] Average minikube: 142.355458 Averages Time Per Log
|
I was able to build the ISO locally and run
iostat
(included in sysstat) andstrace
in the minikube VM.