Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance analysis packages to minikube ISO #5942

Merged
merged 4 commits into from
Dec 2, 2019

Conversation

priyawadhwa
Copy link

@priyawadhwa priyawadhwa commented Nov 18, 2019

I was able to build the ISO locally and run iostat (included in sysstat) and strace in the minikube VM.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #5942 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5942   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files         110      110           
  Lines        8214     8214           
=======================================
  Hits         2972     2972           
  Misses       4851     4851           
  Partials      391      391

@priyawadhwa priyawadhwa changed the title Add iostat and strace packages to minikube ISO Add sysstat and strace packages to minikube ISO Nov 18, 2019
@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 20, 2019
@kubernetes kubernetes deleted a comment from minikube-bot Nov 20, 2019
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 149.748629 149.672289 147.801738]
All Times Minikube (PR 5942): [ 147.548811 141.685353 148.189047]

Average minikube: 149.074219
Average Minikube (PR 5942): 145.807737

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5942) |
+----------------------+-----------+--------------------+
| minikube v           |  0.368424 |           0.380001 |
| Creating kvm2        | 45.513839 |          43.791066 |
| Preparing Kubernetes | 56.294397 |          56.366884 |
| Pulling images       | 16.843826 |          16.076112 |
| Launching Kubernetes | 21.910866 |          20.745528 |
| Waiting for cluster  |  8.086132 |           8.395511 |
+----------------------+-----------+--------------------+

@priyawadhwa priyawadhwa changed the title Add sysstat and strace packages to minikube ISO Add performance analysis packages to minikube ISO Nov 22, 2019
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 146.488917 143.049999 145.451923]
All Times Minikube (PR 5942): [ 150.525675 149.171766 149.461124]

Average minikube: 144.996946
Average Minikube (PR 5942): 149.719522

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5942) |
+----------------------+-----------+--------------------+
| minikube v           |  0.406338 |           0.405139 |
| Creating kvm2        | 47.736547 |          44.900137 |
| Preparing Kubernetes | 51.346409 |          57.783503 |
| Pulling images       | 16.742433 |          17.235827 |
| Launching Kubernetes | 21.288318 |          21.743889 |
| Waiting for cluster  |  7.414514 |           7.586086 |
+----------------------+-----------+--------------------+

@afbjorklund
Copy link
Collaborator

afbjorklund commented Nov 25, 2019

@priyawadhwa: Do we really need to add python ? Or can we run it from containers instead ?

@priyawadhwa
Copy link
Author

@afbjorklund @medyagh python was included as a dependency of iotop, but actually it seems that iotop is installed by another package and seems to work fine. I've removed BR2_PACKAGE_PYTHON and BR2_PACKAGE_IOTOP

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 142.352473 144.481445 140.232455]
All Times Minikube (PR 5942): [ 142.317308 140.741512 141.158398]

Average minikube: 142.355458
Average Minikube (PR 5942): 141.405740

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5942) |
+----------------------+-----------+--------------------+
| minikube v           |  0.375301 |           0.380887 |
| Creating kvm2        | 45.771656 |          45.984888 |
| Preparing Kubernetes | 50.851302 |          49.956430 |
| Pulling images       | 16.778521 |          16.182744 |
| Launching Kubernetes | 21.111212 |          21.443338 |
| Waiting for cluster  |  7.413833 |           7.402146 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 3635b69 into kubernetes:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants