-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update-context to use KUBECONFIG when the env is set #6090
Fix update-context to use KUBECONFIG when the env is set #6090
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: govargo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
/assign @RA489 |
/ok-to-test |
Thank you! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When user executes
minikube update-context
withKUBECONFIG
env, the command fails.This is because the
update-context
uses only$HOME/.kube/config
(KUBECONFIG
env will be ignored).This PR allows users to use
KUBECONFIG
env when they executeminikube update-context
If the
KUBECONFIG
env is not set,$HOME/.kube/config
filepath will be used.Which issue(s) this PR fixes:
Fixes #5944
Does this PR introduce a user-facing change?
Yes.
This PR fixes bug when the user executes
KUBECONFIG=xxxx minikube update-context
Before this PR,
KUBECONFIG=xxxx minikube update-context
command may fail(update-context uses$HOME/.kube/config
)After this PR,
KUBECONFIG=xxxx minikube update-context
command successesAdditional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: