Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'profiles list' to work even if a profile has no control plane #6450

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes bug seen in #6409 integration test.

Libraries should never cause fatal exits.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2020
@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #6450 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
+ Coverage   37.68%   37.69%   +0.01%     
==========================================
  Files         128      128              
  Lines        8654     8674      +20     
==========================================
+ Hits         3261     3270       +9     
- Misses       4970     4979       +9     
- Partials      423      425       +2
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile_list.go 3.94% <0%> (ø) ⬆️
cmd/minikube/cmd/delete.go 27.41% <0%> (-1.02%) ⬇️
pkg/minikube/cluster/cluster.go 37.59% <0%> (-0.68%) ⬇️
pkg/minikube/config/profile.go 69.29% <0%> (+1.97%) ⬆️

@tstromberg tstromberg merged commit 15c6a8a into kubernetes:master Jan 31, 2020
@tstromberg
Copy link
Contributor Author

I confirmed this works to display nodes created with older releases of minikube.

E0131 14:43:00.246474   61424 profile_list.go:85] "vupgrade-20200131T144125.325621-58653" has no control plane: could not find master node
|-------------------------------------------|------------|----------------|-----------|--------------------|---------|
|                  Profile                  | VM Driver  |     NodeIP     | Node Port | Kubernetes Version | Status  |
|-------------------------------------------|------------|----------------|-----------|--------------------|---------|
| containerd-20200131T144125.32588-58653    | virtualbox |                |      8444 | v1.17.2            |         |
| crio-20200131T144125.326867-58653         | virtualbox | 192.168.99.253 |      8443 | v1.15.7            | Running |
| docker-flags-20200131T144125.325604-58653 | virtualbox |                |      8443 | v1.17.2            |         |
| functional-20200131T143927.684822-58653   | virtualbox | 192.168.99.247 |      8443 | v1.17.2            | Running |
| newest-cni-20200131T144125.325885-58653   | virtualbox |                |      8443 | v1.17.2            |         |
| old-docker-20200131T144125.325738-58653   | virtualbox |                |      8443 | v1.11.10           | Running |
| vupgrade-20200131T144125.325621-58653     | virtualbox |                |         0 | v1.11.10           | Running |
|-------------------------------------------|------------|----------------|-----------|--------------------|---------|
⚠️  Found 1 invalid profile(s) ! 
	 minikube
💡  You can delete them using the following command(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants