-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 'profiles list' to work even if a profile has no control plane #6450
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #6450 +/- ##
==========================================
+ Coverage 37.68% 37.69% +0.01%
==========================================
Files 128 128
Lines 8654 8674 +20
==========================================
+ Hits 3261 3270 +9
- Misses 4970 4979 +9
- Partials 423 425 +2
|
I confirmed this works to display nodes created with older releases of minikube.
|
Fixes bug seen in #6409 integration test.
Libraries should never cause fatal exits.