-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kubeadm pull images #6514
Remove kubeadm pull images #6514
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
|
Error: running mkcmp: exit status 1 |
seems harmless ! except the lint :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thank you (after fixing the lint )
Codecov Report
@@ Coverage Diff @@
## master #6514 +/- ##
==========================================
+ Coverage 37.95% 37.99% +0.03%
==========================================
Files 138 138
Lines 8708 8673 -35
==========================================
- Hits 3305 3295 -10
+ Misses 4986 4966 -20
+ Partials 417 412 -5
|
All Times minikube: [ 92.541867 94.855101 91.010794] Average minikube: 92.802587 Averages Time Per Log
|
All Times minikube: [ 95.098037 96.543079 94.666911] Average minikube: 95.436009 Averages Time Per Log
|
Since we pull and load all of these images already, we shouldn't need to do it again.