Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubeadm pull images #6514

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

priyawadhwa
Copy link

Since we pull and load all of these images already, we shouldn't need to do it again.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 6, 2020
@tstromberg
Copy link
Contributor

cmd/minikube/cmd/start.go:1299:121: `bootstrapCluster` - `preexisting` is unused (unparam)

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member

medyagh commented Feb 6, 2020

seems harmless ! except the lint :)

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank you (after fixing the lint )

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #6514 into master will increase coverage by 0.03%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6514      +/-   ##
==========================================
+ Coverage   37.95%   37.99%   +0.03%     
==========================================
  Files         138      138              
  Lines        8708     8673      -35     
==========================================
- Hits         3305     3295      -10     
+ Misses       4986     4966      -20     
+ Partials      417      412       -5
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/bootstrapper.go 0% <ø> (ø) ⬆️
cmd/minikube/cmd/start.go 21.98% <40%> (-0.32%) ⬇️

@minikube-pr-bot
Copy link

All Times minikube: [ 92.541867 94.855101 91.010794]
All Times Minikube (PR 6514): [ 95.990387 92.378526 92.436203]

Average minikube: 92.802587
Average Minikube (PR 6514): 93.601705

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6514) |
+----------------------+-----------+--------------------+
| minikube v           |  0.132622 |           0.122999 |
| Creating kvm2        | 19.814765 |          20.227490 |
| Preparing Kubernetes | 48.429546 |          49.544504 |
| Pulling images       |  3.340484 |                    |
| Launching Kubernetes | 19.434305 |          21.078136 |
| Waiting for cluster  |  0.052527 |           0.078927 |
+----------------------+-----------+--------------------+

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@minikube-pr-bot
Copy link

All Times minikube: [ 95.098037 96.543079 94.666911]
All Times Minikube (PR 6514): [ 93.302036 91.164798 90.660122]

Average minikube: 95.436009
Average Minikube (PR 6514): 91.708985

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6514) |
+----------------------+-----------+--------------------+
| minikube v           |  0.133602 |           0.123408 |
| Creating kvm2        | 20.056048 |          19.760522 |
| Preparing Kubernetes | 49.155302 |          49.089956 |
| Pulling images       |  4.001644 |                    |
| Launching Kubernetes | 19.873548 |          20.965838 |
| Waiting for cluster  |  0.242812 |           0.066083 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 9b7573e into kubernetes:master Feb 7, 2020
@priyawadhwa priyawadhwa deleted the rm-pull-images-kubeadm branch February 24, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants