Fix usage of quotes in cruntime format strings #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
And add a missing test for ImageExists function
afbjorklund
force-pushed
the
cruntime-format
branch
from
0ec9357
to
db1cdc4
Compare
|
Error: running mkcmp: exit status 1 |
Codecov Report
@@ Coverage Diff @@
## master #6549 +/- ##
==========================================
+ Coverage 37.88% 38.02% +0.13%
==========================================
Files 137 137
Lines 8676 8676
==========================================
+ Hits 3287 3299 +12
+ Misses 4976 4962 -14
- Partials 413 415 +2
|
tstromberg
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a missing test for ImageExists function
Closes #6544