-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve docker volume clean up #6695
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
All Times minikube: [ 96.789690 92.736590 93.466718] Average minikube: 94.331000 Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple nits
All Times minikube: [ 98.840054 90.664573 94.225274] Average minikube: 94.576634 Averages Time Per Log
|
Travis tests have failedHey @medyagh, TravisBuddy Request Identifier: b84a48a0-5370-11ea-8998-0567e48e04b6 |
All Times minikube: [ 91.572899 93.861664 92.302970] Average minikube: 92.579178 Averages Time Per Log
|
All Times minikube: [ 91.608083 92.092637 94.352951] Average minikube: 92.684557 Averages Time Per Log
|
All Times minikube: [ 95.351499 91.766440 93.939991] Average minikube: 93.685977 Averages Time Per Log
|
All Times minikube: [ 102.370018 91.166727 92.681679] Average minikube: 95.406141 Averages Time Per Log
|
first delete container
then delete volume
then prune abandoned volumes that minikube created