Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docker volume clean up #6695

Merged
merged 13 commits into from
Feb 20, 2020
Merged

improve docker volume clean up #6695

merged 13 commits into from
Feb 20, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 19, 2020

first delete container
then delete volume
then prune abandoned volumes that minikube created

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@medyagh
Copy link
Member Author

medyagh commented Feb 19, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 19, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 96.789690 92.736590 93.466718]
All Times Minikube (PR 6695): [ 94.641803 93.025577 92.068772]

Average minikube: 94.331000
Average Minikube (PR 6695): 93.245384

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6695) |
+----------------------+-----------+--------------------+
| minikube v           |  0.199421 |           0.198625 |
| Creating kvm2        | 21.179756 |          19.978021 |
| Preparing Kubernetes | 49.915507 |          50.388854 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.462942 |          20.638203 |
| Waiting for cluster  |  0.560501 |           0.068607 |
+----------------------+-----------+--------------------+

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits

cmd/minikube/cmd/delete.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/volumes.go Outdated Show resolved Hide resolved
@minikube-pr-bot
Copy link

All Times minikube: [ 98.840054 90.664573 94.225274]
All Times Minikube (PR 6695): [ 91.992647 94.071145 93.499135]

Average minikube: 94.576634
Average Minikube (PR 6695): 93.187642

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6695) |
+----------------------+-----------+--------------------+
| minikube v           |  0.197131 |           0.198264 |
| Creating kvm2        | 21.160072 |          20.303175 |
| Preparing Kubernetes | 50.929265 |          50.048219 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.300951 |          20.589748 |
| Waiting for cluster  |  0.063914 |           0.397301 |
+----------------------+-----------+--------------------+

@TravisBuddy
Copy link

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b84a48a0-5370-11ea-8998-0567e48e04b6

@minikube-pr-bot
Copy link

All Times minikube: [ 91.572899 93.861664 92.302970]
All Times Minikube (PR 6695): [ 93.303984 92.329073 91.883778]

Average minikube: 92.579178
Average Minikube (PR 6695): 92.505612

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6695) |
+----------------------+-----------+--------------------+
| minikube v           |  0.195340 |           0.197381 |
| Creating kvm2        | 19.693408 |          19.863777 |
| Preparing Kubernetes | 49.839513 |          49.039098 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.100833 |          21.130490 |
| Waiting for cluster  |  0.228811 |           0.228020 |
+----------------------+-----------+--------------------+

cmd/minikube/cmd/delete.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/oci.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/oci.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/delete.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/oci.go Show resolved Hide resolved
pkg/drivers/kic/oci/oci.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/oci.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/volumes.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/volumes.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/volumes.go Outdated Show resolved Hide resolved
@minikube-pr-bot
Copy link

All Times minikube: [ 91.608083 92.092637 94.352951]
All Times Minikube (PR 6695): [ 91.848247 91.460899 91.985382]

Average minikube: 92.684557
Average Minikube (PR 6695): 91.764843

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6695) |
+----------------------+-----------+--------------------+
| minikube v           |  0.202883 |           0.197857 |
| Creating kvm2        | 20.146727 |          19.893227 |
| Preparing Kubernetes | 48.976791 |          49.298645 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.211878 |          20.645903 |
| Waiting for cluster  |  0.378398 |           0.063501 |
+----------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

All Times minikube: [ 95.351499 91.766440 93.939991]
All Times Minikube (PR 6695): [ 93.801070 92.086350 90.920582]

Average minikube: 93.685977
Average Minikube (PR 6695): 92.269334

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6695) |
+----------------------+-----------+--------------------+
| minikube v           |  0.200012 |           0.198814 |
| Creating kvm2        | 20.384436 |          19.951999 |
| Preparing Kubernetes | 50.534373 |          49.784695 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.553722 |          20.555543 |
| Waiting for cluster  |  0.060502 |           0.054936 |
+----------------------+-----------+--------------------+

@medyagh medyagh changed the title fix volume clean up improve docker volume clean up Feb 20, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 102.370018 91.166727 92.681679]
All Times Minikube (PR 6695): [ 94.024865 95.279887 94.998757]

Average minikube: 95.406141
Average Minikube (PR 6695): 94.767836

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6695) |
+----------------------+-----------+--------------------+
| minikube v           |  0.212717 |           0.203726 |
| Creating kvm2        | 20.304148 |          19.896046 |
| Preparing Kubernetes | 51.995237 |          50.386275 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.249342 |          20.941609 |
| Waiting for cluster  |  0.054339 |           0.216368 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 0c6ad6f into kubernetes:master Feb 20, 2020
@medyagh medyagh deleted the vol_fix branch May 2, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants