Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in --install-addons flag #6696

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

priyawadhwa
Copy link

Respect --install-addons flag, don't install anything if it is false

Respect --install-addons flag, don't install anything if it is false
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@priyawadhwa
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 19, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 94.713464 93.878937 93.804372]
All Times Minikube (PR 6696): [ 93.395557 91.442822 92.642918]

Average minikube: 94.132257
Average Minikube (PR 6696): 92.493766

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6696) |
+----------------------+-----------+--------------------+
| minikube v           |  0.202234 |           0.203729 |
| Creating kvm2        | 19.875490 |          19.984877 |
| Preparing Kubernetes | 50.586381 |          49.557570 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.096823 |          20.947517 |
| Waiting for cluster  |  0.391112 |           0.239539 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Feb 20, 2020

unit test failure is not related to your PR, travis is crazy today

@medyagh medyagh merged commit 0af5734 into kubernetes:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants