-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kic on mac: add service cmd support #6811
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josedonizetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6811 +/- ##
==========================================
- Coverage 38.43% 38.31% -0.12%
==========================================
Files 142 142
Lines 8711 8737 +26
==========================================
Hits 3348 3348
- Misses 4943 4969 +26
Partials 420 420
|
7c4dac6
to
f390d4b
Compare
I tried it locally on mac, and it works
one suggestion 👍
|
/ok-to-test |
Error: running mkcmp: exit status 1 |
Fix for #6778