-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inverted certificate symlink creation logic #6889
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so so much for fixing and adding integration tests. looks good, feel free to merge after tests pass
Codecov Report
@@ Coverage Diff @@
## master #6889 +/- ##
=========================================
Coverage ? 38.23%
=========================================
Files ? 142
Lines ? 8766
Branches ? 0
=========================================
Hits ? 3352
Misses ? 4993
Partials ? 421
|
All Times minikube: [ 92.692821 92.621067 91.418588] Average minikube: 92.244159 Averages Time Per Log
|
not related to this PR but did we break the service cmd ? I see two failures in both VM and Kic |
Fixes #6577
Now includes integration tests so that we don't accidentally break this feature in the future.