Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted certificate symlink creation logic #6889

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 4, 2020

Fixes #6577

Now includes integration tests so that we don't accidentally break this feature in the future.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2020
@tstromberg tstromberg changed the title Fix inverted certificate symlink logic Fix inverted certificate symlink creation logic Mar 4, 2020
@tstromberg tstromberg requested review from medyagh, priyawadhwa and sharifelgamal and removed request for blueelvis and RA489 March 4, 2020 22:49
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 4, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so so much for fixing and adding integration tests. looks good, feel free to merge after tests pass

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@aa91f39). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6889   +/-   ##
=========================================
  Coverage          ?   38.23%           
=========================================
  Files             ?      142           
  Lines             ?     8766           
  Branches          ?        0           
=========================================
  Hits              ?     3352           
  Misses            ?     4993           
  Partials          ?      421
Impacted Files Coverage Δ
pkg/minikube/command/ssh_runner.go 10.34% <0%> (ø)
pkg/minikube/bootstrapper/certs.go 75.24% <50%> (ø)

@minikube-pr-bot
Copy link

All Times minikube: [ 92.692821 92.621067 91.418588]
All Times Minikube (PR 6889): [ 92.355721 94.622897 92.497570]

Average minikube: 92.244159
Average Minikube (PR 6889): 93.158729

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6889) |
+----------------------+-----------+--------------------+
| minikube v           |  0.203859 |           0.213003 |
| Creating kvm2        | 20.129405 |          19.893777 |
| Preparing Kubernetes | 49.402722 |          50.228153 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.603579 |          21.183984 |
| Waiting for cluster  |  0.226106 |           0.056032 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Mar 4, 2020

not related to this PR but did we break the service cmd ? I see two failures in both VM and Kic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing Corporate Root CA is not working as advertised
5 participants